Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Jun 29, 2024

This is implemented in the Hyperlinks class meaning it effects both the Hyde::url() helper and the global url() function.

Hyde::url('https://example.com/foo');

// Before https://example.com/https://example.com/foo
// After https://example.com/foo

@emmadesilva emmadesilva force-pushed the update-url-helper-to-not-modify-already-qualified-urls branch from 912b4d2 to c886063 Compare June 29, 2024 07:26
@codecov
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a2dfeb8) to head (4b46ce7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1757   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
- Complexity     1749     1750    +1     
=========================================
  Files           181      181           
  Lines          4673     4675    +2     
=========================================
+ Hits           4671     4673    +2     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review June 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant