[2.x] Decouple HydeFront features from the Asset facade #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
dd33f03 to
10407d4
Compare
21 tasks
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
f4a2948 to
97c7b5a
Compare
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
927c621 to
fb80061
Compare
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
fb80061 to
22a7fe7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1907 +/- ##
===========================================================
Coverage 100.00% 100.00%
+ Complexity 1874 1873 -1
===========================================================
Files 191 192 +1
Lines 4948 4944 -4
===========================================================
- Hits 4948 4944 -4 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
63d367a to
ecfafc8
Compare
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
b1fbf91 to
ee69a0a
Compare
emmadesilva
changed the title
See #1904 for why we are skipping the normal deprecation process.
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
4784c1a to
f5b7526
Compare
With the private API we can now use a more specific and cleaner implementation
emmadesilva
force-pushed
the
decouple-hydefront-from-asset-service
branch
from
615239f to
f00db07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the HydeFront-related functionality from the the Asset facade into a new HydeFront facade. This change simplifies the Asset API and separates concerns. This is part of #1904