[2.x] Remove HydeFront version and CDN URL configuration options #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
I can't see a good reason to want to change the version to load assets that are unlikely to work with the versions in the views in the project Hyde version. Changing the CDN URL could be useful if you want to change the host to another CDN provider, but this current system is way too convoluted for that.
emmadesilva
force-pushed
the
remove-hydefront-cdn-customization-options
branch
from
31e6ff6 to
67ae211
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1909 +/- ##
===========================================================
Coverage 100.00% 100.00%
Complexity 1876 1876
===========================================================
Files 192 192
Lines 4954 4954
===========================================================
Hits 4954 4954 ☔ View full report in Codecov by Sentry. |
emmadesilva
changed the title
…omization-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see a good reason to want to change the version to load assets that are unlikely to work with the versions in the views in the project Hyde version.
Changing the CDN URL could be useful if you want to change the host to another CDN provider, but this may be easier to do using a static property. Since these constants are protected, this is something we can do in a minor release if there is demand for it. We would just replace the constants with public static properties (or protected with accessors)
This is a part of #1904