[2.x] Simplify public asset service API #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1910 +/- ##
===========================================================
Coverage 100.00% 100.00%
+ Complexity 1876 1875 -1
===========================================================
Files 192 192
Lines 4954 4951 -3
===========================================================
- Hits 4954 4951 -3 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
simplify-public-asset-service-api
branch
from
4178216 to
6e16df9
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the AssetService API by making the
HYDEFRONT_VERSIONandHYDEFRONT_CDN_URLconstants protected instead of public, as these no longer have any influence outside of the class, after #1910. This change improves encapsulation and reduces the public API surface, but it is a breaking change for any code directly accessing these constants. The PR also removes related unit tests that are no longer applicable due to the change in visibility.