[2.x] Remove the preferQualifiedUrl parameter from the asset helper
#1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1913 +/- ##
===========================================================
Coverage 100.00% 100.00%
+ Complexity 1871 1870 -1
===========================================================
Files 192 192
Lines 4940 4940
===========================================================
Hits 4940 4940 ☔ View full report in Codecov by Sentry. |
21 tasks
emmadesilva
force-pushed
the
normalize-asset-helpers
branch
from
cd9d67f to
4fa420c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1904 and removes the second parameter of the asset helper to automatically assume the user wants a qualified url when a base url is set. Additionally, it makes little sense to set such a configuration at the method level. It also matches Laravel more https://laravel.com/docs/11.x/helpers#method-asset
See #1916