Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Sep 27, 2025

@emmadesilva emmadesilva force-pushed the feat/ensure-parent-directory-exists-method branch 2 times, most recently from 0880b1c to 41836dc Compare September 27, 2025 12:02
@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0b0d49f) to head (870ec04).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #2293   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2049      2050    +1     
===========================================
  Files            198       198           
  Lines           5282      5284    +2     
===========================================
+ Hits            5282      5284    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new convenience method Filesystem::ensureParentDirectoryExists() to simplify the common pattern of ensuring a file's parent directory exists before performing file operations.

  • Added ensureParentDirectoryExists() method to the Filesystem facade
  • Refactored existing code to use the new method instead of manual dirname() calls
  • Updated tests to verify the new method works correctly

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/framework/src/Facades/Filesystem.php Added the new ensureParentDirectoryExists() method with proper documentation
packages/framework/src/Pages/Concerns/BaseMarkdownPage.php Refactored to use new method, removed unused dirname import
packages/framework/src/Console/Helpers/InteractivePublishCommandHelper.php Refactored to use new method instead of manual dirname() call
packages/framework/tests/Unit/FilesystemFacadeUnitTest.php Added comprehensive test coverage for the new method
packages/framework/tests/Unit/InteractivePublishCommandHelperTest.php Updated test expectations to match new method behavior
RELEASE_NOTES.md Added entry documenting the new feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emmadesilva emmadesilva merged commit 3ff7277 into master Sep 27, 2025
20 checks passed
@emmadesilva emmadesilva deleted the feat/ensure-parent-directory-exists-method branch September 27, 2025 15:35
@emmadesilva emmadesilva mentioned this pull request Sep 27, 2025
3 tasks
@emmadesilva emmadesilva changed the title Add a Filesystem::ensureParentDirectoryExists method [2.x] Add a Filesystem::ensureParentDirectoryExists method Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new Filesystem::ensureParentDirectoryExists() method?

2 participants