Skip to content

Conversation

@emmadesilva
Copy link
Member

Updated isDocumentationPage to use is_a for class and subclass detection. Added tests to verify correct attribution handling and isDocumentationPage behavior for DocumentationPage and its subclasses. This is so that this works for child classes.

@emmadesilva emmadesilva requested a review from Copilot October 4, 2025 12:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Improves documentation page detection in MarkdownService to work with DocumentationPage subclasses by replacing direct class comparison with is_a() for inheritance-aware checking.

  • Changed isDocumentationPage() to use is_a() instead of strict class equality
  • Added comprehensive test coverage for DocumentationPage subclass detection

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/framework/src/Framework/Services/MarkdownService.php Updated isDocumentationPage() method to use is_a() for inheritance support
packages/framework/tests/Feature/MarkdownServiceTest.php Added test suite covering attribution handling and isDocumentationPage behavior for DocumentationPage and subclasses

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Updated isDocumentationPage to use is_a for class and subclass detection. Added tests to verify correct attribution handling and isDocumentationPage behavior for DocumentationPage and its subclasses. This is so that this works for child classes.
@emmadesilva emmadesilva force-pushed the fix/documentation-page-detection branch from 2780e27 to e8c2934 Compare October 4, 2025 12:25
@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d3439be) to head (e8c2934).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #2332   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2000      2000           
===========================================
  Files            197       197           
  Lines           5178      5178           
===========================================
  Hits            5178      5178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emmadesilva emmadesilva merged commit 0568d2b into master Oct 4, 2025
20 checks passed
@emmadesilva emmadesilva deleted the fix/documentation-page-detection branch October 4, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants