Skip to content

Main Application layout scaffold#34

Merged
mmaelicke merged 17 commits intomainfrom
app-layout
Mar 3, 2022
Merged

Main Application layout scaffold#34
mmaelicke merged 17 commits intomainfrom
app-layout

Conversation

@mmaelicke
Copy link
Member

@mmaelicke mmaelicke commented Mar 2, 2022

This pull request add the basic split of the original application. This version will keep as much code as possible from the original, to separate issues and errors into the ones that were already present in RUNISapp.py and the ones caused by the splitting.

With this PR merged, we can start to implement the DataManager and plotting components. It is also the foundation to build the docker branch and finally deploy the first versions.

Closes #30
Closes #31
Closes #33
Closes #35

@mmaelicke mmaelicke added this to the Pre-Release milestone Mar 2, 2022
@mmaelicke mmaelicke requested review from AlexDo1 and lucfr March 2, 2022 08:45
@mmaelicke mmaelicke self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #34 (f3cef1f) into main (ad53bf9) will decrease coverage by 4.29%.
The diff coverage is 13.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   21.47%   17.18%   -4.30%     
==========================================
  Files           5       13       +8     
  Lines         489     1199     +710     
==========================================
+ Hits          105      206     +101     
- Misses        384      993     +609     
Impacted Files Coverage Δ
ruins/apps/climate.py 0.00% <0.00%> (ø)
ruins/apps/management.py 0.00% <0.00%> (ø)
ruins/apps/uncertainty.py 0.00% <0.00%> (ø)
ruins/plotting/kde.py 4.00% <4.00%> (ø)
ruins/plotting/weather_data.py 6.84% <6.84%> (ø)
ruins/plotting/maps.py 7.57% <7.57%> (ø)
ruins/apps/weather.py 35.09% <35.09%> (ø)
ruins/components/topic_select.py 100.00% <100.00%> (ø)
ruins/core/data_manager.py 81.63% <0.00%> (+6.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad53bf9...f3cef1f. Read the comment docs.

@mmaelicke mmaelicke marked this pull request as ready for review March 3, 2022 10:24
@mmaelicke mmaelicke merged commit 2e1b73a into main Mar 3, 2022
@mmaelicke mmaelicke deleted the app-layout branch March 3, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

2 participants