You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With this PR in place, the new and highly important DataManager is used throughout the weather app. This should prioritize singleton usage throughout the whole streamlit instance. This should really speed things up, but make user uploads a hell more complicated, which we don't use anyway.
@AlexDo1 you could checkout this branch and run the state of this branch to report issues and errors back. These errors should then be resolved with the next release.
For some reason the tests are no longer running on Github, what did I do wrong?
On my laptop now only the topic_selector test does not run successfully and I'm not sure how to do that either, because I would have to read out the session_state in the test (?), I don't know how to do that.
Can you take over @mmaelicke ?
I removed the topic_selector tests altogether. I can't find any working way to mock a session state. Without that, unittesting anything relying on the state does just not work.
Hm there's the old xarray IO backend error again. Locally on my machine the weather test works..
Yeah, found the issue. There was a test that used the default config and not the test config. Thus, it was trying to load the original data, not the test data, which is not available in GH actions. Should be fixed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR in place, the new and highly important
DataManageris used throughout the weather app. This should prioritize singleton usage throughout the whole streamlit instance. This should really speed things up, but make user uploads a hell more complicated, which we don't use anyway.@AlexDo1 you could checkout this branch and run the state of this branch to report issues and errors back. These errors should then be resolved with the next release.