Skip to content

Merge Weather and Climate explorer#77

Merged
mmaelicke merged 6 commits intomainfrom
weather-climate-merge
May 27, 2022
Merged

Merge Weather and Climate explorer#77
mmaelicke merged 6 commits intomainfrom
weather-climate-merge

Conversation

@mmaelicke
Copy link
Member

@mmaelicke mmaelicke commented May 23, 2022

First draft to merge weather and climate data explorer.

Remaining tasks:

  • Come up with a transition concept between the three explorers
  • make sure session state is emptied, when needed
  • mark placeholders
  • mark missing translation

@mmaelicke mmaelicke added weather explorer climate explorer Issues related to the climate explorer application labels May 23, 2022
@mmaelicke mmaelicke added this to the APP: Weather Data milestone May 23, 2022
@mmaelicke mmaelicke requested review from AlexDo1 and lucfr May 23, 2022 14:35
@mmaelicke mmaelicke self-assigned this May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #77 (d2ecb2f) into main (2dd0f8b) will increase coverage by 0.55%.
The diff coverage is 10.82%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   18.86%   19.41%   +0.55%     
==========================================
  Files          23       21       -2     
  Lines        1882     1890       +8     
==========================================
+ Hits          355      367      +12     
+ Misses       1527     1523       -4     
Impacted Files Coverage Δ
ruins/apps/weather.py 25.60% <10.25%> (-9.62%) ⬇️
ruins/core/config.py 78.16% <100.00%> (-0.25%) ⬇️
ruins/components/model_scale_select.py 19.51% <0.00%> (+19.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd0f8b...d2ecb2f. Read the comment docs.

@mmaelicke mmaelicke marked this pull request as ready for review May 25, 2022 08:18
@mmaelicke mmaelicke linked an issue May 25, 2022 that may be closed by this pull request
Copy link
Collaborator

@AlexDo1 AlexDo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new layout, the app feels much better structured now.

At first glance, everything seems to work. I have only one suggestion: it was not quite clear to me how to navigate from the Weather Explorer to the Climate Explorer, as this option is quite hidden in the sidebar under the "Learn more" button, especially on smaller screens.

I think it would be clearer if we displayed something like "Continue to Climate Explorer" or even the "Learn More" button on the main page rather than in the sidebar.

@AlexDo1
Copy link
Collaborator

AlexDo1 commented May 26, 2022

I think now it is better, looks very good.

@mmaelicke mmaelicke mentioned this pull request May 26, 2022
3 tasks
@mmaelicke mmaelicke linked an issue May 26, 2022 that may be closed by this pull request
3 tasks
@mmaelicke mmaelicke merged commit 7ce31bb into main May 27, 2022
@mmaelicke mmaelicke deleted the weather-climate-merge branch May 27, 2022 06:21
@mmaelicke mmaelicke mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

climate explorer Issues related to the climate explorer application weather explorer

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Remove Topics Bug in weather explorer

2 participants