Skip to content

Add Sunburst plot instead of Bubble plot#87

Merged
mmaelicke merged 7 commits intomainfrom
bubble_plot
Jun 27, 2022
Merged

Add Sunburst plot instead of Bubble plot#87
mmaelicke merged 7 commits intomainfrom
bubble_plot

Conversation

@mmaelicke
Copy link
Member

@AlexDo1,

I implemented the sunburst plot into your bubble_plot branch. The plot is shown on the trasition page from weather explorer to climate explorer, and in the climate explorer itself.
The infobox still needs translation and a better text. That's something for later.

Please review the stuff and, if you like it, we can get rid of the bubble plot routine before merging into the main branch.

@mmaelicke mmaelicke added climate explorer Issues related to the climate explorer application priority: high HIGH priority issue labels Jun 23, 2022
@mmaelicke mmaelicke added this to the APP: Climate Projections milestone Jun 23, 2022
@mmaelicke mmaelicke requested a review from AlexDo1 June 23, 2022 14:40
@mmaelicke
Copy link
Member Author

And btw, I found a way to fix the percentage numbers. Maybe the most over-engineered piece of code I ever wrote :)

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #87 (8d87431) into main (8f43738) will decrease coverage by 0.98%.
The diff coverage is 4.61%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   19.05%   18.07%   -0.99%     
==========================================
  Files          22       25       +3     
  Lines        1926     2053     +127     
==========================================
+ Hits          367      371       +4     
- Misses       1559     1682     +123     
Impacted Files Coverage Δ
ruins/apps/bubbles.py 0.00% <0.00%> (ø)
ruins/plotting/bubble_plot.py 0.00% <0.00%> (ø)
ruins/plotting/cordex_sunburst.py 23.07% <23.07%> (ø)
ruins/apps/weather.py 25.26% <25.00%> (-0.35%) ⬇️
ruins/core/config.py 78.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f43738...8d87431. Read the comment docs.

Copy link
Collaborator

@AlexDo1 AlexDo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new sunburst plot, everything works perfectly.

I just think we need a more detailed explanation of the plot for the final version.

Great that you managed to display the percentages, I just found a small bug with the hovertext display in the innermost circle:
image

The hovertext of the other circles looks good and does not show {customdata[1]}

@mmaelicke mmaelicke requested a review from AlexDo1 June 23, 2022 18:03
@mmaelicke
Copy link
Member Author

I think the problem was, that these labels were empty ( due to missing parent category). Now, I added a '-', which should fix things. Thanks for pointing out.

@AlexDo1
Copy link
Collaborator

AlexDo1 commented Jun 27, 2022

One more problem I just encountered:
The second page of the climate explorer seems to be a bit messed up as everything is displayed at once:

  • The (empty) plot
  • A Select Station #1 header without the option to select a station
  • Climate projection selection

image

@mmaelicke
Copy link
Member Author

Yeah, I don't have a good idea how we can come around this so far. The page might change anyway, so I would postpone this

@AlexDo1
Copy link
Collaborator

AlexDo1 commented Jun 27, 2022

Okay, then we can merge in my opinion, the plot looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

climate explorer Issues related to the climate explorer application priority: high HIGH priority issue

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants