chore(lint): comprehensive lint + structural refactors (dist backend, eviction, middleware)

[hyp3rd]

No description provided.

[trunk-io]

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

[Copilot]

Pull Request Overview

This is a comprehensive lint and structural refactoring PR that applies linting fixes throughout the codebase, focusing on code formatting, error handling improvements, and structural optimizations for the distributed backend, eviction algorithms, and middleware components.

Key changes include:

• Enabled comprehensive linting rules (revive, wsl_v5) with 160+ configuration changes
• Refactored error handling to use errors.Is() for proper error comparison
• Updated loop syntax to use modern Go range patterns (for range N instead of for i := 0; i < N; i++)

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
.golangci.yaml	Added comprehensive revive and wsl_v5 linter configurations
tests/*.go	Applied whitespace formatting, modern loop syntax, and error handling improvements
pkg/eviction/*.go	Refactored eviction algorithms with improved documentation and structural optimizations
pkg/middleware/*.go	Extracted constants for attribute keys and improved code organization
pkg/backend/*.go	Major structural refactoring of distributed memory backend with improved error handling
management_http.go	Split large function into smaller helper methods for better maintainability

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Using errors.Is() with sentinel.ErrKeyExpired assumes it's a wrapped error, but the original direct comparison suggests it's a sentinel value. This could cause false negatives if the error is not wrapped. Consider verifying that sentinel.ErrKeyExpired is properly implemented as a wrapped error or revert to direct comparison.

Suggested change

	shouldExpire := errors.Is(test.expectedErr, sentinel.ErrKeyExpired)
	shouldExpire := test.expectedErr == sentinel.ErrKeyExpired

[Copilot]

The //nolint:ireturn comment appears incorrect here. This function returns a boolean, not an interface, so the ireturn linter should not apply. Consider removing this comment as it's misleading.

Suggested change

	func (c *ClockAlgorithm) tryInsertInFreeSlot(key string, value any) bool { //nolint:ireturn
	func (c *ClockAlgorithm) tryInsertInFreeSlot(key string, value any) bool {

[Copilot]

[nitpick] These error message constants are overly generic and don't provide specific context about the operation. Consider more descriptive names like errMsgCreateHTTPRequest and errMsgExecuteHTTPRequest to improve debugging clarity.

Suggested change

	errMsgDoRequest = "do request"
	errMsgCreateSetRequest = "create set request"
	errMsgExecuteSetRequest = "execute set request"

[Copilot]

Silently ignoring server errors with _ = serveErr makes debugging difficult. Consider logging the error or providing a callback mechanism to handle server startup failures, especially since this is infrastructure code.

Suggested change

	_ = serveErr
	go func() { // capture server errors (log them)
	serveErr := s.app.Listener(ln)
	if serveErr != nil { // separated for noinlineerr linter
	log.Printf("distHTTPServer: server error: %v", serveErr)