Add comprehensive edge case tests for NoSQL operator detection#36
Closed
Copilot wants to merge 5 commits intofeat/sanitizefrom
Closed
Add comprehensive edge case tests for NoSQL operator detection#36Copilot wants to merge 5 commits intofeat/sanitizefrom
Copilot wants to merge 5 commits intofeat/sanitizefrom
Conversation
Co-authored-by: hyp3rd <62474964+hyp3rd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on NoSQL injection detector implementation
Add comprehensive edge case tests for NoSQL operator detection
Jan 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances test coverage for NoSQL injection detection by adding comprehensive edge case tests that verify correct behavior for boundary conditions in dollar sign parsing and operator identification.
Changes:
- Restructured
TestNoSQLInjectionDetectorEdgeCaseswith improved naming (shouldErrinstead ofwantError) - Added 25 test cases covering dollar signs at string end, non-alphabetic followers, unknown operators, all boundary delimiters, and false positive scenarios
- Simplified test assertion logic for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses missing test coverage for boundary conditions in NoSQL injection detection logic, specifically around dollar sign parsing and operator identification.
Changes
Edge cases for dollar signs: Tests for
$at string end ("price$"), followed by non-alphabetic chars ("$123","$_id"), and with unknown operators ("$unknown")Boundary delimiter coverage: Tests for operators after all delimiters from
isNoSQLOperatorBoundary({,[,,,:,",',(), plus whitespace variants (space, tab, newline)False positive prevention: Tests ensuring mid-word operators (
"test$nevalue") and legitimate dollar usage don't trigger detectionAdded 24 test cases in
TestNoSQLInjectionDetectorEdgeCasesusing table-driven approach for clarity and maintainability.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.