Add comprehensive edge case tests for NoSQL operator detection#38
Merged
hyp3rd merged 3 commits intofeat/sanitizefrom Jan 11, 2026
Merged
Add comprehensive edge case tests for NoSQL operator detection#38hyp3rd merged 3 commits intofeat/sanitizefrom
hyp3rd merged 3 commits intofeat/sanitizefrom
Conversation
Co-authored-by: hyp3rd <62474964+hyp3rd@users.noreply.github.com>
…rcase Co-authored-by: hyp3rd <62474964+hyp3rd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update configurable options for NoSQL injection detector
Add comprehensive edge case tests for NoSQL operator detection
Jan 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive edge case test coverage for NoSQL injection operator detection, addressing feedback from PR #35 that requested broader boundary case testing.
Changes:
- Added
TestNoSQLInjectionDetectorEdgeCaseswith 26 test cases covering dollar sign positions, unknown operators, various delimiters, and case normalization - Tests validate the detector correctly distinguishes legitimate dollar sign usage from injection patterns based on operator boundary logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #35 requesting broader test coverage for NoSQL injection operator detection boundary cases.
Changes
TestNoSQLInjectionDetectorEdgeCaseswith 26 test cases covering:"price$","$123","price$value""$unknown","$hello"{,[,,,:,",',(, whitespace"$NE","$Ne"correctly detected (operators are lowercased)Tests validate the detector correctly distinguishes legitimate dollar sign usage from injection patterns based on the
isNoSQLOperatorBoundarylogic.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.