Expand test coverage for secrets detection and redaction package#43
Merged
hyp3rd merged 2 commits intofeat/secretsfrom Jan 12, 2026
Merged
Expand test coverage for secrets detection and redaction package#43hyp3rd merged 2 commits intofeat/secretsfrom
hyp3rd merged 2 commits intofeat/secretsfrom
Conversation
Co-authored-by: hyp3rd <62474964+hyp3rd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update secrets detection and redaction package based on PR feedback
Expand test coverage for secrets detection and redaction package
Jan 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR significantly expands test coverage for the secrets detection and redaction package, addressing code review feedback on PR #42. The changes add comprehensive test coverage for error conditions, edge cases, configuration options, and complex nested structure handling, bringing test coverage from minimal baseline to 72.6%.
Changes:
- Added 16 test functions with 29 subtests covering error handling, edge cases, and configuration options
- Validated error conditions for input length limits and invalid configurations
- Tested complex nested structures including 3+ level deep maps and slices containing maps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #42 identifying missing test coverage for error conditions, edge cases, configuration options, and nested structure handling.
Tests Added
Error Handling
ErrSecretInputTooLongfor all detection methodsSecretDetectorandRedactor(empty/invalid masks, invalid depths, empty patterns/keys)Edge Cases
Configuration Options
WithSecretPattern/WithSecretPatterns- custom pattern detectionWithSecretMaxLength/WithSecretMask- input limits and custom maskingWithRedactionKeys- case-insensitive key matchingWithRedactionMaxDepth- recursion depth controlComplex Structures
Coverage Impact
Test coverage: 72.6% of statements (up from minimal baseline)
All 16 test functions with 29 subtests passing.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.