Add test coverage for missing tlsconfig option functions#50
Merged
hyp3rd merged 1 commit intofeat/tlsconfigfrom Jan 13, 2026
Merged
Add test coverage for missing tlsconfig option functions#50hyp3rd merged 1 commit intofeat/tlsconfigfrom
hyp3rd merged 1 commit intofeat/tlsconfigfrom
Conversation
Merged
Copilot
AI
changed the title
[WIP] WIP address feedback on Feat/tlsconfig pull request
Add test coverage for missing tlsconfig option functions
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses missing test coverage for option functions in
pkg/tlsconfig/config.goidentified in PR #49 review feedback.Changes
WithServerName,WithRootCAs,WithNextProtos,WithCurvePreferencesWithGetCertificate,WithGetClientCertificate,WithInsecureSkipVerifyWithKeyLogWriterandWithMaxVersionTests follow existing patterns in the package, covering both success and error cases where applicable.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.