Conversation
- go.mod/go.sum: update github.com/hyp3rd/hyperlogger from v0.0.8 → v0.0.9 - .pre-commit-ci-config.yaml: update yamllint hook from v1.37.1 → v1.38.0 Rationale: keep dependencies and lint tooling current; no application code changes.
…s, and update libs - Toolchain: set GO_VERSION to 1.25.6 in .project-settings.env, Makefile, and go.mod; update pre-commit toolchain_version to 1.25.6. - CI (gitleaks): upgrade actions/checkout from v4 → v6; tweak triggers/cron comment. - CI (proto): rename job (settings → proto); switch from job outputs to PROTO_ENABLED env var; add conditional steps (lint/format/generate/diff); refresh actions versions. - Deps: bump github.com/hyp3rd/ewrap to v1.3.6 and github.com/hyp3rd/hyperlogger to v0.1.0; update go.sum. No application code changes—tooling/CI and dependency maintenance only.
There was a problem hiding this comment.
Pull request overview
This PR updates Go toolchain version from 1.25.5 to 1.25.6 and updates two dependencies (ewrap and hyperlogger). It also refactors the proto.yml GitHub Actions workflow to consolidate job steps, updates the yamllint pre-commit hook version, and improves the gitleaks workflow configuration.
Changes:
- Upgraded Go version from 1.25.5 to 1.25.6 across all configuration files
- Updated dependencies: ewrap (1.3.5 → 1.3.6) and hyperlogger (0.0.8 → 0.1.0)
- Refactored proto.yml workflow by removing separate settings job and consolidating into single proto job
- Updated yamllint from v1.37.1 to v1.38.0 and gitleaks workflow from actions/checkout@v4 to v6
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go version to 1.25.6 and dependency versions for ewrap and hyperlogger |
| go.sum | Updated checksums for ewrap v1.3.6 and hyperlogger v0.1.0 |
| Makefile | Updated GO_VERSION variable to 1.25.6 |
| .project-settings.env | Updated GO_VERSION to 1.25.6 |
| .pre-commit/unit-test-hook | Updated hardcoded toolchain version to 1.25.6 |
| .pre-commit-ci-config.yaml | Updated yamllint version to v1.38.0 |
| .github/workflows/proto.yml | Refactored workflow to remove separate settings job and consolidate all steps into single proto job with conditional execution based on PROTO_ENABLED |
| .github/workflows/gitleaks.yml | Updated to actions/checkout@v6, added permissions block, improved formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| PROTO_ENABLED: true |
There was a problem hiding this comment.
The PROTO_ENABLED environment variable is hardcoded to 'true' at the job level, but .project-settings.env sets PROTO_ENABLED=false. This means the workflow will always run proto steps even when PROTO_ENABLED is false in the project settings, overriding the configuration. The env value should either be removed or sourced from the project settings file.
| env: | |
| PROTO_ENABLED: true |
| if: needs.settings.outputs.proto_enabled == 'true' | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| echo "PROTO_ENABLED=${PROTO_ENABLED:-true}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
This line sets PROTO_ENABLED to the environment variable again after it was already set at line 14. Since line 14 hardcodes it to 'true', this step will not have the intended effect of reading the value from .project-settings.env (which is 'false'). The job-level env at line 14 should be removed to allow this step to properly set the value from the settings file.
1 participant
No description provided.