Skip to content

Conversation

@shrisukhani
Copy link
Contributor

@shrisukhani shrisukhani commented Dec 3, 2025

Summary

  • Fixed bug where GeminiClient.invoke() was not passing temperature and maxOutputTokens to the API
  • The invokeStructured() method correctly included these parameters, but invoke() did not
  • This caused users' temperature settings to be silently ignored for regular (non-structured) Gemini calls

Changes

Added the missing config block to match invokeStructured():

config: {
  temperature: options?.temperature ?? this.temperature,
  maxOutputTokens: options?.maxTokens ?? this.maxTokens,
},

Test plan

  • Verify TypeScript compiles without errors
  • Test Gemini provider with explicit temperature setting to confirm it's respected

🤖 Generated with Claude Code


Note

GeminiClient.invoke now forwards temperature and maxTokens (as config.maxOutputTokens) to the Gemini API.

  • Gemini provider (src/llm/providers/gemini.ts):
    • Add config to invoke request, forwarding temperature and maxOutputTokens to the API.

Written by Cursor Bugbot for commit d3fba9b. This will update automatically on new commits. Configure here.

The invoke() method was not passing temperature and maxOutputTokens
to the Gemini API, unlike invokeStructured() which correctly included
these parameters. This meant users' temperature settings were silently
ignored for regular (non-structured) Gemini calls.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants