fix/cli rawmode guard #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invoke() method was not passing temperature and maxOutputTokens to the Gemini API, unlike invokeStructured() which correctly included these parameters. This meant users' temperature settings were silently ignored for regular (non-structured) Gemini calls. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Guard CLI keypress/raw-mode behind TTY checks and send temperature/maxTokens to Gemini generateContent.
src/cli/index.ts):process.stdin.setRawMode(true)behindprocess.stdin.isTTY.onStep,debugAgentOutput, and after follow-up prompt inonComplete.src/llm/providers/gemini.ts):configtogenerateContentwithtemperatureandmaxOutputTokenssourced from options/defaults.Written by Cursor Bugbot for commit 9435909. This will update automatically on new commits. Configure here.