Fix action cache extract #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Tightens instruction/objective handling in action cache and replay, adding validation for
extractand safer fallbacks when instructions are missing.src/agent/index.ts):extractreplay: requirestep.instruction; fail with clear error if missing; wrap extraction in try/catch with error reporting.performhelpers: passperformInstructionasnullwhen absent; if no valid helper and noinstruction, return FAILED with explanatory message.src/agent/shared/action-cache.ts):extractInstructionto returnobjectiveforextract, requireinstructionforactElement, and allowundefinedfor actions that don't need instructions.src/types/agent/types.ts):ActionCacheEntry.instructiontostring | undefinedto reflect optional instructions.Written by Cursor Bugbot for commit f18519b. This will update automatically on new commits. Configure here.