Skip to content

Conversation

@Dingway98
Copy link
Contributor

@Dingway98 Dingway98 commented Dec 9, 2025

Note

Tightens instruction/objective handling in action cache and replay, adding validation for extract and safer fallbacks when instructions are missing.

  • Agent runtime (src/agent/index.ts):
    • Validate extract replay: require step.instruction; fail with clear error if missing; wrap extraction in try/catch with error reporting.
    • perform helpers: pass performInstruction as null when absent; if no valid helper and no instruction, return FAILED with explanatory message.
  • Action cache (src/agent/shared/action-cache.ts):
    • Refactor extractInstruction to return objective for extract, require instruction for actElement, and allow undefined for actions that don't need instructions.
  • Types (src/types/agent/types.ts):
    • Change ActionCacheEntry.instruction to string | undefined to reflect optional instructions.

Written by Cursor Bugbot for commit f18519b. This will update automatically on new commits. Configure here.

@Dingway98 Dingway98 merged commit 6cb0500 into main Dec 9, 2025
2 checks passed
@Dingway98 Dingway98 deleted the fix-action-cache-extract branch December 9, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants