fix(sds-demo): update collaboration modal to use granular permissions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the collaboration modal in sds-demo uses the old read/write permission model when granting access to collaborators. This is a problem because commit d2e0b12 updated the grantAccess lexicon to require granular permissions (read, create, update, delete) instead of the write boolean. When users attempt to add collaborators via the UI, the API returns HTTP 400 with error "Input/permissions must have the property \"create\"". This patch solves the problem by updating the collaboration modal to use the granular permission model. Role definitions (viewer, contributor, admin) now specify create, update, and delete permissions instead of a single write boolean. Also removes unused permissions state variable and RepositoryPermissions import that are no longer needed. Co-authored-by: Composer <noreply@cursor.com>
|
Someone is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, the collaboration modal in sds-demo uses the old read/write permission model when granting access to collaborators.
This is a problem because commit d2e0b12 updated the
grantAccesslexicon to require granular permissions (read, create, update, delete) instead of the write boolean. When users attempt to add collaborators via the UI, the API returns HTTP 400 with errorInput/permissions must have the property "create".This patch solves the problem by updating the collaboration modal to use the granular permission model. Role definitions (viewer, contributor, admin) now specify create, update, and delete permissions instead of a single write boolean. Also removes unused permissions state variable and
RepositoryPermissionsimport that are no longer needed.Co-authored-by: Composer noreply@cursor.com