Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

Conversation

@ikappaki
Copy link

@ikappaki ikappaki commented Apr 4, 2024

Hi,

can you please review change to rename cljfmt configuration file, it fixes #20.

The config file includes non-edn clj code, and thus have to be renamed to the .clj extension.

Tested it to work locally:

$ cljfmt.exe check
src\electric_starter_app\main.cljc has incorrect formatting
--- a\src\electric_starter_app\main.cljc
+++ b\src\electric_starter_app\main.cljc
@@ -9,7 +9,7 @@
     (binding [dom/node js/document.body]
       (dom/h1 (dom/text "Hello from Electric Clojure"))
       (dom/p (dom/text "Source code for this page is in ")
-             (dom/code (dom/text "src/electric_start_app/main.cljc")))
+        (dom/code (dom/text "src/electric_start_app/main.cljc")))
       (dom/p (dom/text "Make sure you check the ")
         (dom/a (dom/props {:href "https://electric.hyperfiddle.net/" :target "_blank"})
           (dom/text "Electric Tutorial"))))))
1 file(s) formatted incorrectly

thanks

@dustingetz
Copy link
Member

Thank you for the PR, we will take a look after we wrap up our current sprint. I see it's a trivial change (file rename only) but we do need to validate, and likely also propagate this to other repos so I can't just click the button unfortunately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cljfmt config issue

2 participants