Import six standalone and gfortran9(?) bugfix#220
Merged
astrofrog merged 3 commits intohyperion-rt:masterfrom May 14, 2020
Merged
Import six standalone and gfortran9(?) bugfix#220astrofrog merged 3 commits intohyperion-rt:masterfrom
astrofrog merged 3 commits intohyperion-rt:masterfrom
Conversation
Replacing all imports with a try/except. Also added vscode config directory to gitignore.
Segfault happened because an optional variable value wasn't defined. Adjusting value write format to be E instead of F.
astrofrog
reviewed
Apr 9, 2020
Contributor
Author
|
No problem! I can make these changes this week and update the PR. Thanks for the feedback. |
Contributor
Author
|
Okay, I've made these changes! |
Contributor
|
Thanks! |
dnarayanan
added a commit
to dnarayanan/hyperion
that referenced
this pull request
May 14, 2020
Merge pull request hyperion-rt#220 from jwise77/six-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astropy doesn't package six anymore, so I replaced all of its imports with a try/except with an import from a standalone module. There was a similar issue with pytest. I didn't include six in the
install_requiresto be backwards compatible with previous installs. This addresses #219.I fixed a segfault (I'm using gfortran v9.2.1) that came from an optional argument not having a default value. I also changed the write format of the percentile value during the iterations because my runs had very large values.