Skip to content

Fix continuous integration#230

Merged
astrofrog merged 10 commits intohyperion-rt:mainfrom
astrofrog:fix-ci
Aug 18, 2023
Merged

Fix continuous integration#230
astrofrog merged 10 commits intohyperion-rt:mainfrom
astrofrog:fix-ci

Conversation

@astrofrog
Copy link
Copy Markdown
Contributor

Work in progress!

@astrofrog astrofrog force-pushed the fix-ci branch 2 times, most recently from 7a4c80a to 1a7e08c Compare February 17, 2023 15:48
@astrofrog
Copy link
Copy Markdown
Contributor Author

Looks like the difference is due to changes in the source positions:

position        y of </Sources/source_03567> y of </Sources/source_03567> difference          
------------------------------------------------------------
                -9.0529         -9.0529         1.77636e-15  

In some cases. We could also try and make the source names more reproducible to minimize diffs between HDF5 files but that's less important. So need to figure out why in e.g. test_ptsource_vertices_noclip the source positions are changing.

@astrofrog
Copy link
Copy Markdown
Contributor Author

The numerical differences appear to be due to numpy/numpy#19478

@astrofrog
Copy link
Copy Markdown
Contributor Author

Possible fix would be to use:

            export NPY_DISABLE_CPU_FEATURES=AVX512_SKX

but need to check how we would force Numpy to install from source.

@astrofrog astrofrog marked this pull request as ready for review August 18, 2023 11:38
@astrofrog astrofrog merged commit 24c9492 into hyperion-rt:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant