Fix continuous integration#230
Merged
astrofrog merged 10 commits intohyperion-rt:mainfrom Aug 18, 2023
Merged
Conversation
7a4c80a to
1a7e08c
Compare
Contributor
Author
|
Looks like the difference is due to changes in the source positions: In some cases. We could also try and make the source names more reproducible to minimize diffs between HDF5 files but that's less important. So need to figure out why in e.g. |
Contributor
Author
|
The numerical differences appear to be due to numpy/numpy#19478 |
Contributor
Author
|
Possible fix would be to use: but need to check how we would force Numpy to install from source. |
e0292e9 to
98e5b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress!