Fix compatibility with and enable limited API#237
Merged
astrofrog merged 16 commits intohyperion-rt:mainfrom Apr 21, 2024
Merged
Fix compatibility with and enable limited API#237astrofrog merged 16 commits intohyperion-rt:mainfrom
astrofrog merged 16 commits intohyperion-rt:mainfrom
Conversation
astrofrog
commented
Aug 23, 2023
| for (i = 0; i < n_wall_args; ++i) { | ||
| // NOTE: PyTuple_GetItem returns a borrowed reference, no need to handle refcount. | ||
| wall_args_arr[i] = PyFloat_AS_DOUBLE(PyTuple_GetItem(wall_args_obj,(Py_ssize_t)i)); | ||
| // wall_args_arr[i] = PyFloat_AS_DOUBLE(PyTuple_GetItem(wall_args_obj,(Py_ssize_t)i)); |
Contributor
Author
There was a problem hiding this comment.
Need to fix this!
astrofrog
force-pushed
the
limited-api
branch
5 times, most recently
from
d18ab48 to
9f30e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete, one of the lines in the Voronoi wrapper code needs updating