Skip to content

status: make as_str return &'static str #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhgg wants to merge 1 commit into from
Closed

status: make as_str return &'static str #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
//! ```

use std::convert::TryFrom;
use std::num::NonZeroU16;
use std::error::Error;
use std::fmt;
use std::num::NonZeroU16;
use std::str::FromStr;

/// An HTTP status code (`status-code` in RFC 7230 et al.).
Expand Down Expand Up @@ -132,18 +132,22 @@ impl StatusCode {
/// assert_eq!(status.as_str(), "200");
/// ```
#[inline]
pub fn as_str(&self) -> &str {
pub fn as_str(&self) -> &'static str {
let offset = (self.0.get() - 100) as usize;
let offset = offset * 3;

// Invariant: self has checked range [100, 999] and CODE_DIGITS is
// ASCII-only, of length 900 * 3 = 2700 bytes

#[cfg(debug_assertions)]
{ &CODE_DIGITS[offset..offset+3] }
{
&CODE_DIGITS[offset..offset + 3]
}

#[cfg(not(debug_assertions))]
unsafe { CODE_DIGITS.get_unchecked(offset..offset+3) }
unsafe {
CODE_DIGITS.get_unchecked(offset..offset + 3)
}
}

/// Get the standardised `reason-phrase` for this status code.
Expand Down Expand Up @@ -516,9 +520,7 @@ status_codes! {

impl InvalidStatusCode {
fn new() -> InvalidStatusCode {
InvalidStatusCode {
_priv: (),
}
InvalidStatusCode { _priv: () }
}
}

Expand Down