Enable simpler header name parser in debug builds#521
Closed
ibraheemdev wants to merge 4 commits intohyperium:masterfrom
ibraheemdev:master
Closed
Enable simpler header name parser in debug builds#521ibraheemdev wants to merge 4 commits intohyperium:masterfrom ibraheemdev:master
ibraheemdev wants to merge 4 commits intohyperium:masterfrom
ibraheemdev:master
Conversation
Contributor
|
If we're going to do this, it seems like it might also be a good idea to add a CI step to run the tests in release mode? Otherwsie, most of the parser code is no longer tested on CI. |
Member
|
Maybe I'm misunderstanding... Seems this is turning off the debug assertions? |
Author
|
It makes it so the simpler version of |
Member
|
I'd normally think in a debug build we'd want the extra checks. |
Contributor
|
#499 removes the |
Author
|
Closing in favor of #499. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves close to a second off debug builds on my machine.