feat(path-and-query): allow utf8 char, not rfc 3986 compliant, in path and query#715
Merged
seanmonstar merged 2 commits intohyperium:masterfrom Dec 20, 2024
Conversation
joelwurtz
changed the title
joelwurtz
force-pushed
the
feat/allow-utf8-in-path-and-query
branch
from
13d7c10 to
ee7266d
Compare
seanmonstar
approved these changes
Dec 20, 2024
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Thanks for submitting this! After talking with a few other people, this seems like the right way to go.
Contributor
Author
|
Thanks for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of a PR in seanmonstar/httparse#178
This is mainly to allow incoming request that may have utf8 char in their path or query as some browsers send them raw instead of doing a percent encode (see the details here : actix/actix-web#3102 (comment) for a list of browser doing that)
This patch allow to correctly build a request object based on this behavior
I made it simple for the moment as i don't know how you want to handle this, in a feature flag ? through an option ? neither of them ?
Also i don't know on which version this should be based, it seems that 0.2 still receive some support should it be backported to this version also ?