Skip to content

Conversation

@reem
Copy link
Contributor

@reem reem commented Apr 3, 2015

We can revert this PR when rust-lang/rust#23995 lands, but it won't
land until after beta is cut.

We can revert this PR when rust-lang/rust#23995 lands, but it won't
land until after beta is cut.
@seanmonstar
Copy link
Member

There was a problem?

@reem
Copy link
Contributor Author

reem commented Apr 3, 2015

The Unicase changes broke master

@reem
Copy link
Contributor Author

reem commented Apr 3, 2015

I was on my phone earlier - to be a little more clear:

Unicase changed to use AsRef instead of Deref for its impls. The impl of AsRef for Cow is overly restrictive, so this causes breakage. The linked PR fixes this, but won't be in beta. It would be nice to build on beta.

seanmonstar added a commit that referenced this pull request Apr 3, 2015
fix(headers): Add CowStr as a temporary hack to build on beta.
@seanmonstar seanmonstar merged commit cc8400d into hyperium:master Apr 3, 2015
@reem reem deleted the cowstr-hack branch April 6, 2015 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants