add mime types for marckdown, latex, vega, geojson, fasta#92
Open
davidB wants to merge 4 commits intohyperium:masterfrom
Open
add mime types for marckdown, latex, vega, geojson, fasta#92davidB wants to merge 4 commits intohyperium:masterfrom
davidB wants to merge 4 commits intohyperium:masterfrom
Conversation
Author
|
can you merge the PR ? |
seanmonstar
reviewed
Dec 28, 2018
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Sorry I missed the notification before! We can certainly these types in.
| VEGALITE_V2, "vnd.vegalite.v2+json"; | ||
| VEGALITE_V3, "vnd.vegalite.v3+json"; | ||
| PLOTY, "vnd.plotly.v1+json"; | ||
| GEOJSON, "geo+json"; |
Member
There was a problem hiding this comment.
Some of these new Name constants are actually a subtype+suffix. They should probably be removed, because this would be confusing:
// assertion fails
assert_eq!(APPLICATION_GEOJSON.subtype(), GEOJSON);
Author
There was a problem hiding this comment.
I was not sur about adding them in the section "common application/*", may be could remove them all (there are not so common.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoses mime-types are used in Machine Learning community (Jupyter, JupyterLab).
Please review, I'm not sure to do the right changes.
Thanks.
FYI I started a PR to use mime with https://github.com/google/evcxr
PS: I also note that the code is not formatted with rustfmt (I had to disable format-on-save on my editor)