Combine error messages for maxItems and minItems #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
requested changes
Jan 29, 2026
Collaborator
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good so far. Please add tests.
Contributor
Author
|
Thank you for the review. I will add tests. |
Contributor
Author
|
I have added tests |
Contributor
Author
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When multiple
minItemsormaxItemsconstraints fail (e.g., via allOf), this PR consolidates the resulting error messages into a single, clear message.It selects the highest
minItemsvalue and the lowestmaxItemsvalue, ensuring that only the most restrictive constraints are reported.Fixes: Issue #136
Testing: All tests pass.