Incorporate an optional title parameter into the AddAssetQuantity and SubtractAssetQuantity function for the Python client, aligning with the enhanced functionality within Iroha Core for optimized message communication.

[dominious1]

Introduce an optional title parameter to the commands.proto bufs GRPC for AddAssetQuantity and SubtractAssetQuantity. This enhancement facilitates a more flexible and comprehensive feature set, aligning with evolving requirements and ensuring seamless integration with the protobuf-based GRPC implementation.

Technology stack:

• Ubuntu 22.04.3 LTS
• Python 3.10
• PyCharm
• protoc libprotoc 23.1

To regenerate files based on predefined protobufs I used iroha-python/scripts/compile-proto.py

This is part of internship project:
https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments

Link to PR to iroha repository compatible with those changes:
hyperledger-iroha/iroha#4003

[baziorek]

You changed *.proto file, but You need to generate code. Please execute:

scripts/compile-proto.py

[dominious1]

Generated files added after adding new parameter.

[baziorek]

Generated files added after adding new parameter.

Great!

As I remember there were some problems with protobuf files when they were generated with too new protobuf. Please provide some information how You generated those files, what is Your OS? What version is of protoc in Your system?

And one more think - please correct DCO:

when You click "Details" You will see commands how to fix

[andprogrammer]

This is okay.

[andprogrammer]

This is okay.

[baziorek]

commands.proto looks OK, rest of files are generated, so probably they are also OK. So next thing is to finish: hyperledger-iroha/iroha#4003

[baziorek]

Yesterday I was having meeting with @dominious1 and @andprogrammer . We corrected name from title->description and regenerated python files from protobuf with official script(https://github.com/hyperledger/iroha-python/blob/main/scripts/compile-proto.py).

[andprogrammer]

Fantastic pull request. Thank you.

[baziorek]

To make sure that everything is working I checked:

1. I've build Iroha 1 from main (all changes are merged)
2. I've performed commands to install from the PR locally:

mkdir checking_internship
cd checking_internship
python -m venv $(pwd)/venv
source ./venv/bin/activate
pip3 install git+https://github.com/dominious1/iroha-python.git@addtitleparamtoAddAssetQuantity

3. Then I run attached code: code.py (code.zip)
   Most important part of the file is running the function:

def add_coin_to_admin_with_description(asset: str, amount='1000.00', desc=''):
    """
    Add provided amount of specific units to admin account
    """
    tx = iroha.transaction([
        iroha.command('AddAssetQuantity',
                      asset_id=asset, amount=amount, description=desc)
    ])
    IrohaCrypto.sign_transaction(tx, ADMIN_PRIVATE_KEY)
    send_transaction_and_print_status(tx)

4. The output contained those commands (full output in file: fullOputput.txt )"

  transactions {
    payload {
      reduced_payload {
        commands {
          add_asset_quantity {
            asset_id: "coin#domain"
            amount: "102"
            description: "Testing description"
          }
        }
        creator_account_id: "admin@test"
        created_time: 1707045588320
        quorum: 1
      }
    }
    signatures {
      public_key: "313a07e6384776ed95447710d15e59148473ccfc052a681317a72a69f2a49910"
      signature: "7a904afaaa208fdb9ec0695e4c6f6acb3f36578d2af46741c143a9e3726b8de0b1b71fc323bdc0c27fbbdbe939298393476dd5b89d1e390e424004185a8cb101"
    }
  }

5. I've checked in blocks files - the transaction is available amoungh commands:

jq '.blockV1.payload.transactions[0].payload.reducedPayload' < 0000000000000004
{
  "commands": [
    {
      "addAssetQuantity": {
        "assetId": "coin#domain",
        "amount": "102",
        "description": "Testing description"
      }
    }
  ],
  "creatorAccountId": "admin@test",
  "createdTime": "1707045588320",
  "quorum": 1
}

IMO it is done - fully working!

[6r1d]

LGTM, thank you for your contribution. I'm concerned that we have blobs inside the Python code, and this is a topic I'd like to discuss separately.

[6r1d]

LGTM, thank you for your contribution. I'm concerned that we have blobs inside the Python code, and this is a topic I'd like to discuss separately.