eth_config prototype #8417

shemnon · 2025-03-13T18:54:01Z

PR description

A prototype for eth_cofig, sharing operational client configuration data
via RPC.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

spotless: ./gradlew spotlessApply
unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

siladu

Adding this as context for reviewers https://hackmd.io/@shemnon/eth_config

siladu · 2025-03-13T23:46:12Z

ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_config.json

+    "result": {
+      "current": {
+        "activation": 1444660040,
+        "blobs": {


Suggested change

"blobs": {

"blobSchedule": {

Think we should align with genesis naming

siladu · 2025-03-13T23:47:16Z

ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_config.json

+    "id": 8,
+    "result": {
+      "current": {
+        "activation": 1444660040,


Suggested change

"activation": 1444660040,

"activationTime": 1444660040,

Could this ever include blockNumber activation forks? Maybe for other networks?

Two things, (a) the EIP limits itself to post-merge networks and (b) block numbers for mainnet and tesnets will always be less than the point in 2015 when ethereum launched.

Also, unless we are going to see it on mainnet or the testnets I don't think we should put it in EIPs. Rollups with shorter block times that present an issue for this can post a RRC. So it can be moved to activationTime, but I wouldn't specify anything for blocks.

L2s that adopt it and have block based activatons could update the eth_config generation file and add it.

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java

siladu · 2025-03-14T00:16:31Z

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java

+    spec.getBlockHashProcessor()
+        .getHistoryContract()
+        .ifPresent(a -> contracts.put("HISTORY", a.toHexString()));
+    if (!contracts.isEmpty()) {


Do we need something for the BEACON_ROOTS_ADDRESS too? https://github.com/ethereum/EIPs/blob/2fb744367e5a65ff3afaf30025cba27ec36b1b3f/EIPS/eip-4788.md?plain=1#L34

It can be added. This would be an example of a true constant being reported, as the beacon root is not configurable in Besu -

besu/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ParentBeaconBlockRootHelper.java

Line 40 in 821daf1

final MutableAccount account = worldUpdater.getAccount(BEACON_ROOTS_ADDRESS);

Thus it serves two good purposes - (a) a vale for Cancun systemContracts and (b) an example of serving up a compiled constant.

This would be an example of a true constant being reported, as the beacon root is not configurable in Besu

Isn't this already the case with the precompiles and some of the other system contracts like HISTORY_STORAGE_ADDRESS?

HISTORY_STORAGE_ADDRESS is a variable inside the besu implementations, and had multiple values in devnets. When I called BEACON_ROOTS_ADDRESS a constant I was referring to Besu code.

siladu · 2025-03-14T00:20:42Z

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java

+                .orElse(Map.of()));
+    spec.getBlockHashProcessor()
+        .getHistoryContract()
+        .ifPresent(a -> contracts.put("HISTORY", a.toHexString()));


would be nice to match the EIP name IMO i.e. HISTORY_STORAGE_ADDRESS (and same for the other contracts)

Think precision is good here as perhaps there will be future contracts that require similar names, e.g. the confusion around "withdrawals" vs "withdrawal requests".

Do you have a naming proposal? 2935_HISTORY perhaps?

How about precompiles, should we add the EIP number to the name? What about modexp, which has had multiple tweaks to the gas schedule, would the eip be the most recent one?

I think it should match the name given in the EIP, i.e HISTORY_STORAGE_ADDRESS

I wouldn't object to including the EIP number too, although it is already encoded in the vanity address (though not consistently). However, my comment is less concerned about linking it to an EIP, rather than making it precise enough that a future system contract name is unlikely to collide.

Undecided if we should include EIP number to the precompiles, but if so then maybe the EIP it was introduced in would be more stable?
As an alternative, perhaps more precise naming is also warranted there...how likely is it that a future precompile collides? e.g. a new version of modexp alongside the old?

.../org/hyperledger/besu/evm/precompile/BigIntegerModularExponentiationPrecompiledContract.java

* implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com>

Signed-off-by: Danno Ferrin <danno@numisight.com>

github-actions · 2025-05-04T02:14:48Z

This pr is stale because it has been open for 30 days with no activity.

github-actions · 2025-05-18T02:15:04Z

This pr was closed because it has been inactive for 14 days since being marked as stale.

siladu · 2025-05-20T00:17:13Z

Reopening as think we should get this in

jframe · 2025-05-26T23:29:05Z

@shemnon Would you be happy for this to go in as is? We can always update this when the spec is updated.

shemnon · 2025-05-27T04:00:54Z

I'd feel better if at least one other client had implemented it. But sure, go ahead.

github-actions · 2025-06-27T02:14:18Z

This pr is stale because it has been open for 30 days with no activity.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java

siladu

Wonder if we should add fork names into their as well, for convenience.

siladu · 2025-07-08T00:34:22Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/DefaultProtocolSchedule.java

  }

+  @Override
+  public Optional<ScheduledProtocolSpec> getNextProtocolSpec(final long currentTime) {


Think we should have a test for this, but can be follow on PR.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

* Feature/required besu native (hyperledger#8418) * implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix gradle verification (hyperledger#8435) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * eth_config prototype A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com> * review comments Signed-off-by: Danno Ferrin <danno@numisight.com> * update precompile names Signed-off-by: Danno Ferrin <danno@numisight.com> * Refactor how next fork is calculated Signed-off-by: Danno Ferrin <danno@numisight.com> * copyright Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

* Feature/required besu native (hyperledger#8418) * implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix gradle verification (hyperledger#8435) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * eth_config prototype A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com> * review comments Signed-off-by: Danno Ferrin <danno@numisight.com> * update precompile names Signed-off-by: Danno Ferrin <danno@numisight.com> * Refactor how next fork is calculated Signed-off-by: Danno Ferrin <danno@numisight.com> * copyright Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>

siladu mentioned this pull request Mar 13, 2025

Explicitly add depositContractAddress to mainnet.json #8410

Merged

9 tasks

siladu reviewed Mar 14, 2025

View reviewed changes

ahamlat reviewed Mar 14, 2025

View reviewed changes

.../org/hyperledger/besu/evm/precompile/BigIntegerModularExponentiationPrecompiledContract.java Outdated Show resolved Hide resolved

siladu mentioned this pull request Mar 17, 2025

Add Hoodi as named network #8428

Merged

9 tasks

shemnon force-pushed the eth_config branch from 843ba48 to f317043 Compare March 19, 2025 20:03

garyschulte and others added 5 commits April 3, 2025 13:07

Feature/required besu native (hyperledger#8418)

d24144b

* implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com>

Fix gradle verification (hyperledger#8435)

a3ed58c

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

eth_config prototype

f985cf8

A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com>

review comments

78d6b44

Signed-off-by: Danno Ferrin <danno@numisight.com>

update precompile names

5158fad

Signed-off-by: Danno Ferrin <danno@numisight.com>

shemnon force-pushed the eth_config branch from e3cefcd to 5158fad Compare April 3, 2025 19:16

Refactor how next fork is calculated

1902059

Signed-off-by: Danno Ferrin <danno@numisight.com>

github-actions bot added the Stale label May 4, 2025

github-actions bot closed this May 18, 2025

siladu reopened this May 20, 2025

github-actions bot removed the Stale label May 20, 2025

github-actions bot added the Stale label Jun 27, 2025

macfarla added 3 commits June 27, 2025 13:31

copyright

8ea332a

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

updated with osaka gas limit calculator refactoring

7b0929a

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

formatting

be2353d

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla reviewed Jun 27, 2025

View reviewed changes

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java Outdated Show resolved Hide resolved

.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthConfig.java Outdated Show resolved Hide resolved

Merge branch 'main' of github.com:hyperledger/besu into eth_config

5981a07

github-actions bot removed the Stale label Jun 28, 2025

Merge branch 'main' into eth_config

14fcfcb

macfarla marked this pull request as ready for review June 30, 2025 02:54

Gabriel-Trintinalia added this to Osaka Jul 4, 2025

Gabriel-Trintinalia assigned macfarla Jul 4, 2025

Gabriel-Trintinalia moved this to In Progress in Osaka Jul 4, 2025

Merge branch 'main' into eth_config

08f6a0c

siladu approved these changes Jul 8, 2025

View reviewed changes

changelog

1afa208

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

siladu enabled auto-merge (squash) July 8, 2025 01:29

siladu merged commit 4b82d2f into hyperledger:main Jul 8, 2025
53 of 67 checks passed

github-project-automation bot moved this from In Progress to Done in Osaka Jul 8, 2025

eth_config prototype #8417

eth_config prototype #8417

Conversation

shemnon commented Mar 13, 2025

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siladu Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siladu Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 4, 2025

Uh oh!

github-actions bot commented May 18, 2025

Uh oh!

siladu commented May 20, 2025

Uh oh!

jframe commented May 26, 2025

Uh oh!

shemnon commented May 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

siladu Mar 17, 2025 •

edited

Loading

siladu Mar 17, 2025 •

edited

Loading