Skip to content

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 9, 2025

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the remove-txpool-disable-locals branch from dfe4c51 to 8460351 Compare May 9, 2025 08:16
@fab-10 fab-10 marked this pull request as ready for review May 9, 2025 08:16
@fab-10 fab-10 added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label May 9, 2025
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the remove-txpool-disable-locals branch from 8460351 to d1e1fbd Compare May 9, 2025 08:50
@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label May 11, 2025
@macfarla macfarla changed the title Remove then deprecated --tx-pool-disable-locals option Remove the deprecated --tx-pool-disable-locals option May 11, 2025
fab-10 and others added 2 commits May 13, 2025 10:03
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) May 13, 2025 08:04
@fab-10 fab-10 merged commit 00a18e2 into hyperledger:main May 13, 2025
48 checks passed
@fab-10 fab-10 deleted the remove-txpool-disable-locals branch May 13, 2025 08:57
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants