Route ModExp precompile in certain conditions #8868
Merged
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
Author
|
results of the benchmarks attached, with improvements all across the board: |
siladu
approved these changes
Jun 28, 2025
| final int modulusLength = clampedToInt(length_of_MODULUS); | ||
| if ((extractLastByte(input, baseOffset, baseLength) & 1) != 1 | ||
| && (extractLastByte(input, modulusOffset, modulusLength) & 1) != 1) { | ||
| return computeNative(input, length_of_MODULUS); |
Contributor
There was a problem hiding this comment.
maybe could pass int modulusLength instead of recalculating?
lu-pinto
force-pushed
the
route-modexp-precompile
branch
from
1169432 to
a38cd40
Compare
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
route-modexp-precompile
branch
from
a38cd40 to
74b580a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This is a cherry-pick from the performance branch that we used to test the changes in the latest interop.
original PR: #8758
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests