Adjust history expiry related flags #8875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake non-hidden, and default to enabled Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
macfarla
reviewed
Jun 30, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
also needs a changelog entry
app/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/hyperledger/besu/cli/options/storage/DataStorageOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…rOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ags' into adjust-history-expiry-related-flags
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ags' into adjust-history-expiry-related-flags
macfarla
reviewed
Jun 30, 2025
app/src/main/java/org/hyperledger/besu/cli/options/storage/DataStorageOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
…aStorageOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ags' into adjust-history-expiry-related-flags
siladu
requested changes
Jun 30, 2025
Contributor
siladu
left a comment
siladu
left a comment
There was a problem hiding this comment.
Probably should promote the -Xplugin-rocksdb...garbage-collection... settings too but maybe can leave for a followup PR. It will make the docs a bit messy to have a mix of experimental but not the end of the world
app/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Show resolved
Hide resolved
app/src/main/java/org/hyperledger/besu/cli/options/storage/DataStorageOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ags' into adjust-history-expiry-related-flags
siladu
approved these changes
Jun 30, 2025
Contributor
siladu
left a comment
siladu
left a comment
There was a problem hiding this comment.
LGTM, minor changelog fix
Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Set up history expiry flags as desired
Fixed Issue(s)
#8653