Backward sync - check we have peers before starting #9003

macfarla · 2025-07-25T01:36:46Z

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Don't start backward sync if zero peers.

change isReady check to ensure we have > 0 peers
check isReady before first step of backward sync

Fixed Issue(s)

Fixes #8072

Testing performed to verify this PR prevents the issue described in #8072

nodes set up with frequent restarts to trigger frequent backward syncs
this PR prevents backward sync from starting before the node finds peers
details in comments below

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

spotless: ./gradlew spotlessApply
unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla · 2025-07-30T05:28:25Z

Currently running an experiment to see if I can replicate to test this out

4 nodes running besu + nimbus on this PR
2 nodes running commit d690980 ie main right before this PR
all 6 are being restarted every 2h with a copy of the nightly jenkins job that updates & restarts the nightly nodes, which were showing the issue Besu can't backward sync after a restart. #8072

Hypothesis being the 2 controls will experience the issue in #8072 and the 4 nodes running this PR will not.

macfarla · 2025-08-01T00:09:43Z

zgrep -E "BackwardSyncAlgorithm|BackwardSyncContext" besu.log.1.gz
control - you can see that backward sync frequently tries to start when the node still has zero peers


{"@timestamp":"2025-07-31T10:31:09,428","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 2069 blocks. Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T10:31:09,429","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T12:20:34,237","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T12:20:34,242","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0xb7c22390a2721834f2c523133f0c8b48661ffdfde4654d198940524f9a1c567f from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T12:20:34,242","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T12:20:36,660","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T12:20:37,549","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23039043, target head 23039046). Peers: 2","throwable":""}
{"@timestamp":"2025-07-31T12:20:38,802","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 2","throwable":""}
{"@timestamp":"2025-07-31T12:20:38,803","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T14:20:20,631","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T14:20:20,637","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0xea24168a53b8d49d32c1626ac050c2de9d94cbe25b55c809484037cb97c074b0 from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T14:20:20,637","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T14:20:24,907","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T14:20:28,216","level":"INFO","thread":"nioEventLoopGroup-3-5","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23039638, target head 23039641). Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T14:20:29,165","level":"INFO","thread":"nioEventLoopGroup-3-5","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 7","throwable":""}
{"@timestamp":"2025-07-31T14:20:29,165","level":"INFO","thread":"ForkJoinPool.commonPool-worker-5","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T16:20:13,970","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T16:20:13,977","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0xa4f4e73e0e0ea0331590c601f5b6dd9e9db62c08e30be08c6728574e5ea4273b from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T16:20:13,977","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T16:20:25,647","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T16:20:30,044","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23040234, target head 23040238). Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T16:20:31,198","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T16:20:31,199","level":"INFO","thread":"ForkJoinPool.commonPool-worker-2","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T18:20:19,674","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T18:20:19,682","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0x8a43c6361fdf24647f253242b95748c37671fa8c7b308a95af987b95f41759fe from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T18:20:19,683","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T18:20:24,616","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T18:20:30,473","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23040826, target head 23040829). Peers: 6","throwable":""}
{"@timestamp":"2025-07-31T18:20:31,452","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 7","throwable":""}
{"@timestamp":"2025-07-31T18:20:31,452","level":"INFO","thread":"ForkJoinPool.commonPool-worker-1","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T20:20:10,572","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T20:20:10,579","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0xb0fea7cee7ff0352c12f34ac3adb15b3b85dd3824e9f383dc697e7ce6cf26825 from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T20:20:10,579","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T20:20:13,098","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T20:20:14,872","level":"INFO","thread":"nioEventLoopGroup-3-6","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23041421, target head 23041424). Peers: 2","throwable":""}
{"@timestamp":"2025-07-31T20:20:16,146","level":"INFO","thread":"nioEventLoopGroup-3-6","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T20:20:16,147","level":"INFO","thread":"ForkJoinPool.commonPool-worker-4","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T22:20:15,494","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T22:20:15,505","level":"WARN","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Unable to retrieve block 0xcd6e21221d37a6e492782a9b083457878ef9d8df6031e2e455a1ecf28ca09c91 from any peer, with 0 peers available. Could be a reorged block. Waiting for the next block from the consensus client to try again.","throwable":""}
{"@timestamp":"2025-07-31T22:20:15,505","level":"INFO","thread":"EthScheduler-Workers-0","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T22:20:15,642","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T22:20:21,247","level":"INFO","thread":"ForkJoinPool.commonPool-worker-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23042014, target head 23042017). Peers: 3","throwable":""}
{"@timestamp":"2025-07-31T22:20:23,748","level":"INFO","thread":"nioEventLoopGroup-3-5","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T22:20:23,749","level":"INFO","thread":"ForkJoinPool.commonPool-worker-4","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}

macfarla · 2025-08-01T00:13:01Z

logs from node running this PR - backward sync does not start while node still has zero peers

zgrep -E "BackwardSyncAlgorithm|BackwardSyncContext" besu.log.1.gz
{"@timestamp":"2025-07-31T00:20:14,676","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T00:20:18,928","level":"INFO","thread":"nioEventLoopGroup-3-2","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23035470, target head 23035473). Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T00:20:20,342","level":"INFO","thread":"nioEventLoopGroup-3-2","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T00:20:20,343","level":"INFO","thread":"ForkJoinPool.commonPool-worker-6","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T02:20:26,361","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T02:20:30,834","level":"INFO","thread":"nioEventLoopGroup-3-1","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23036068, target head 23036072). Peers: 6","throwable":""}
{"@timestamp":"2025-07-31T02:20:32,026","level":"INFO","thread":"nioEventLoopGroup-3-1","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 7","throwable":""}
{"@timestamp":"2025-07-31T02:20:32,027","level":"INFO","thread":"ForkJoinPool.commonPool-worker-1","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T04:20:24,938","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T04:20:28,238","level":"INFO","thread":"nioEventLoopGroup-3-4","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23036664, target head 23036668). Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T04:20:29,528","level":"INFO","thread":"nioEventLoopGroup-3-4","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T04:20:29,528","level":"INFO","thread":"ForkJoinPool.commonPool-worker-6","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T06:20:24,029","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T06:20:27,229","level":"INFO","thread":"nioEventLoopGroup-3-4","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23037259, target head 23037262). Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T06:20:28,964","level":"INFO","thread":"nioEventLoopGroup-3-4","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T06:20:28,964","level":"INFO","thread":"ForkJoinPool.commonPool-worker-1","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T08:20:36,452","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T08:20:37,332","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23037854, target head 23037858). Peers: 4","throwable":""}
{"@timestamp":"2025-07-31T08:20:38,730","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T08:20:38,731","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T09:42:02,984","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T09:42:13,072","level":"INFO","thread":"nioEventLoopGroup-3-1","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 12.45% completed, imported 32 blocks of at least 257 (current head 23038039, target head 23038264). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:42:23,173","level":"INFO","thread":"nioEventLoopGroup-3-1","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 27.34% completed, imported 70 blocks of at least 256 (current head 23038077, target head 23038263). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:42:33,700","level":"INFO","thread":"nioEventLoopGroup-3-1","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 41.25% completed, imported 106 blocks of at least 257 (current head 23038113, target head 23038264). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:42:43,761","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 57.36% completed, imported 148 blocks of at least 258 (current head 23038155, target head 23038265). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:42:53,811","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 70.27% completed, imported 182 blocks of at least 259 (current head 23038189, target head 23038266). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:43:03,941","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 83.08% completed, imported 216 blocks of at least 260 (current head 23038223, target head 23038267). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:43:14,397","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 97.71% completed, imported 256 blocks of at least 262 (current head 23038263, target head 23038269). Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:43:17,980","level":"INFO","thread":"nioEventLoopGroup-3-10","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 261 blocks. Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:43:18,147","level":"INFO","thread":"ForkJoinPool.commonPool-worker-28","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 262 blocks. Peers: 25","throwable":""}
{"@timestamp":"2025-07-31T09:43:18,148","level":"INFO","thread":"ForkJoinPool.commonPool-worker-28","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T10:20:25,138","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T10:20:34,083","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23038448, target head 23038452). Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T10:20:35,689","level":"INFO","thread":"nioEventLoopGroup-3-6","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T10:20:36,067","level":"INFO","thread":"nioEventLoopGroup-3-6","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 6 blocks. Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T10:20:36,067","level":"INFO","thread":"ForkJoinPool.commonPool-worker-4","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T10:21:26,879","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T10:21:34,663","level":"INFO","thread":"ForkJoinPool.commonPool-worker-2","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23038454, target head 23038457). Peers: 16","throwable":""}
{"@timestamp":"2025-07-31T10:21:35,633","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 16","throwable":""}
{"@timestamp":"2025-07-31T10:21:35,633","level":"INFO","thread":"ForkJoinPool.commonPool-worker-1","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T10:21:41,078","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T10:21:46,368","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 1 blocks. Peers: 18","throwable":""}
{"@timestamp":"2025-07-31T10:21:46,813","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 2 blocks. Peers: 18","throwable":""}
{"@timestamp":"2025-07-31T10:21:46,813","level":"INFO","thread":"ForkJoinPool.commonPool-worker-2","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T12:20:36,660","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T12:20:43,072","level":"INFO","thread":"nioEventLoopGroup-3-5","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23039043, target head 23039046). Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T12:20:44,199","level":"INFO","thread":"nioEventLoopGroup-3-5","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T12:20:44,200","level":"INFO","thread":"ForkJoinPool.commonPool-worker-2","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T14:20:24,891","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T14:20:28,440","level":"INFO","thread":"nioEventLoopGroup-3-7","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23039638, target head 23039641). Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T14:20:29,388","level":"INFO","thread":"nioEventLoopGroup-3-7","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 5","throwable":""}
{"@timestamp":"2025-07-31T14:20:29,388","level":"INFO","thread":"ForkJoinPool.commonPool-worker-4","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T16:20:25,611","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T16:20:26,273","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 20.00% completed, imported 1 blocks of at least 5 (current head 23040234, target head 23040238). Peers: 13","throwable":""}
{"@timestamp":"2025-07-31T16:20:27,487","level":"INFO","thread":"ForkJoinPool.commonPool-worker-6","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 5 blocks. Peers: 15","throwable":""}
{"@timestamp":"2025-07-31T16:20:27,487","level":"INFO","thread":"ForkJoinPool.commonPool-worker-6","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T18:20:24,704","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T18:20:26,669","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23040826, target head 23040829). Peers: 8","throwable":""}
{"@timestamp":"2025-07-31T18:20:27,677","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 9","throwable":""}
{"@timestamp":"2025-07-31T18:20:27,678","level":"INFO","thread":"ForkJoinPool.commonPool-worker-3","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T20:20:13,117","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T20:20:14,956","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23041421, target head 23041424). Peers: 2","throwable":""}
{"@timestamp":"2025-07-31T20:20:16,168","level":"INFO","thread":"nioEventLoopGroup-3-3","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 2","throwable":""}
{"@timestamp":"2025-07-31T20:20:16,180","level":"INFO","thread":"ForkJoinPool.commonPool-worker-2","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}
{"@timestamp":"2025-07-31T22:20:24,652","level":"INFO","thread":"vert.x-worker-thread-0","class":"BackwardSyncContext","message":"Starting a new backward sync session","throwable":""}
{"@timestamp":"2025-07-31T22:20:29,177","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2, 25.00% completed, imported 1 blocks of at least 4 (current head 23042015, target head 23042018). Peers: 9","throwable":""}
{"@timestamp":"2025-07-31T22:20:30,542","level":"INFO","thread":"nioEventLoopGroup-3-8","class":"BackwardSyncContext","message":"Backward sync phase 2 of 2 completed, imported a total of 4 blocks. Peers: 7","throwable":""}
{"@timestamp":"2025-07-31T22:20:30,543","level":"INFO","thread":"ForkJoinPool.commonPool-worker-7","class":"BackwardSyncAlgorithm","message":"Current backward sync session is done","throwable":""}

pinges · 2025-08-05T05:51:14Z

...c/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncAlgSpecTest.java

    backwardChain.addNewHash(hash);
    doReturn(CompletableFuture.completedFuture(null)).when(algorithm).executeSyncStep(hash);

+    doReturn(true).when(context).isReady();


You haven't got a test case for when we have 0 peers.

added to BackwardSyncContextTest.

…-wait-for-peers

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

pinges

LGTM

* docs: edited the badge that was displayed incorrectly (#8623) * Update README.md Signed-off-by: Olexandr88 <radole1203@gmail.com> * Update README.md Signed-off-by: Jason Frame <jasonwframe@gmail.com> --------- Signed-off-by: Olexandr88 <radole1203@gmail.com> Signed-off-by: Jason Frame <jasonwframe@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jason Frame <jasonwframe@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> * getBlobsV2 prohibits partial responses (#8967) * getBlobsV2 to not return partial responses Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Change precompile name in eth_config (#8986) * Change precompile name in eth_config The precompile names for bn254 were encoded as bn256, which is a widely used but incorrect name. The EIP specified alt_bn128, for 128 bits of security, but cryptographic analysis has shown the security to be less than 128 bits, so the name referring to the field size is preferred. Signed-off-by: Danno Ferrin <danno@numisight.com> * fixed test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * remove separate qbft ATs gradle task and workflow (#8962) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove deprecated method Quantity.getValue (#8968) * update tests to use non-deprecated method * remove deprecated method * remove getValue methods that overrode the removed method Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Clean up production of the fastSyncFactory in DefaultSynchronizer (#8975) * Clean up production of the fastSyncFactory in DefaultSynchronizer Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix NPE caused by using a mock SynchronizerConfiguration Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix NPE caused by using a mock SynchronizerConfiguration Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Avoid using syncMode directly Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * remove deprecated PoAMetricsService and IbftQueryService (#8940) * remove deprecated interfaces * update plugin api hash Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * refactor: central control point for genesis used in tests (#8819) * made a constant Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Rename block hash processor (#8993) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Generate distribution dependencies catalog (#8987) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * feat: add world view to traceStartBlock hook (#8981) * Add world view to trace start block Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * change known hash Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * fix unit tests Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Do not account for system calls in the tracer (#8992) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Remove PoW ATs which were replaced by QBFT miner based ATs (#8949) * Delete PoW ATs which were replaced by QBFT miner based ATs * Change another AT to used QBFT genesis * update node config to fix couple of AT failures * Update transaction validator AT to use 4 validators in QBFT cluster * Update Besueventsplugintest * Revert an accidentally deleted AT and now modified to use QBFT Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Improve BENCHMARKING.md documentation (#9001) Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net> * Docker labels update (#9002) * fix docker build Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> * update docker labels to the new oci standard Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> --------- Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> * No RLP decoding of Bodies during the sync (fix #8242) (#8959) * By not decoding the bodies we use less memory and CPU, which allows us to increase the chain download parallelism. Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> * Enable decoding for large RPC requests (#8877) Use maxRequestContentLength for EngineJsonRpcService bodyLimit and increase default value from 5MB to 128MB. This has a side effect of increasing the JsonRpcService limit. Use maxRequestContentLength to globally set maxStringLength for Vertx ObjectMapper when engine API enabled. Reusing maxRequestContentLength to keep aligned with HTTP body limit. String length should be comparable with byte size assuming UTF-8 encoding. Also remove redundant serialization of params for optionalList Similar to #8807 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * Add --attempt-cache-bust to evmtool benchmark subcommand (#8985) This means running all the test cases within one warmup or exec iteration in an attempt to invalidate CPU caches. Requires tracking exec timings in a map and calculating average at the end. Reduce warmup iteration to 20_000 and execution iterations to 1000, which appears to be as stable as 100_000. This helps reduces overall benchmark execution time (previously warmTime and execTime were prematurely reducing overall execution time). Use SequencedMap to indicate test case ordering matters. Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * TransactionDecoder: handle empty bytes (#8997) * handle empty bytes * check for empty before getting tx type Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Add a message for disconnect message reasons (#9014) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Remove the possibility to create block before Byzantium hard-fork (#9005) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * chore: remove support for eth/67 (#9008) * remove eth/67 capability Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * fix naming Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * changelog Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Fix mock test Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Fix tests Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * fix tests Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Improve info logs during block creation (#9020) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Chore: Prevent repeated cli boolean flags for being accepted (#8898) * Chore: Prevent repeated cli boolean flags for being accepted Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> * allow unmatched options Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> * Eliminate AbstractRLPInput abstraction to reduce technical debt (#8885) Merge AbstractRLPInput (607 lines) and BytesValueRLPInput (84 lines) into a single concrete class implementing RLPInput directly. This eliminates the unnecessary abstraction layer where the abstract class had only one concrete implementation. Changes: - Merged all AbstractRLPInput logic into BytesValueRLPInput - Made previously protected methods private - Removed AbstractRLPInput.java file - All public APIs remain unchanged (zero breaking changes) - All tests pass unchanged Benefits: - Eliminates 15-30 minutes investigation time per RLP modification - Reduces cognitive load when working with RLP functionality - Simplifies maintenance with single concrete implementation - No performance or functionality impact Fixes #8884 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: jflo <justin+github@florentine.us> Co-authored-by: Claude <noreply@anthropic.com> * Add WorldStateService to the plugin API (#9024) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Change eth_config hashing and config members (#9015) * Change eth_config hashing and config members - Remove ConfigHash - move ForkID into config - invert key/value of precompiles Signed-off-by: Danno Ferrin <danno@numisight.com> * linting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Era1 import prepipeline qol improvements (#8964) * Add --era1-import-prepipeline-enabled and --era1-data-path flags Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Implement ERA1 file import prepipeline for full sync Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Filter out block 0 as this is included by default Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix SynchronizerOptionsTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix BesuCommandTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Add ability to load ERA1 files direct from HTTP source, fix bug in Era1Reader exposed by using HTTP source Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix Era1ReaderTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Add javadoc to InputStreamFactory Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Add default constructor to InputStreamFactory Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix Era1FileSourceTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Only produce era1 import prepipeline if sync mode is FULL Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Make era1 prepipeline concurrency configurable Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use Integer instead of int in SynchronizerOptions Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Update era1 import prepipeline concurrency to 1 Since the bottleneck for this pipeline is typically the import block step, there is no need for more concurrency than a single pipeline gives. Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> * Inline starting full sync chain downloader Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Simplify comment Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use constant for era1 block count Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use Era1FileReader as a launching point for more worker threads to achieve better parallelism Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> * Eliminate AbstractRLPOutput abstraction to reduce technical debt (#8890) - Consolidate AbstractRLPOutput logic into BytesValueRLPOutput - Remove unnecessary inheritance layer with single implementation - Maintain identical public API and functionality - Zero breaking changes to 150+ usage sites across codebase This follows the same pattern as recent AbstractRLPInput elimination, completing the removal of premature abstractions in the RLP module. Fixes #8889 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: jflo <justin+github@florentine.us> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * [BESU-8973] Display configured target-gas-limit in startup logs (#8998) * [BESU-8973] Fix issue #8973 * Added `targetGasLimit` property and related setter to `ConfigurationOverviewBuilder` class * Added line to `build` function for `targetGasLimit` in `ConfigurationOverviewBuilder` class * Added set of `targetGasLimit` for `builder` object in `generateConfigurationOverview` of `BesuCommand` class * Set default value for `targetGasLimit` in `BesuCommand` class * Changed visibility of `normalizeGas` in `ConfigurationOverviewBuilder` class for usage in tests * Added `getDefaultGasLimitByChainId` method in `MergeCoordinator` * Added tests for `MergeCoordinator`, `ConfigurationOverviewBuilder` and `BesuCommandTest` * Tests for mainnet, testnet and dev with default and custom targetGasLimit * Replaced Sepolia with Hoodi for MergeCoordinatorTest Signed-off-by: Gabriele Del Monte <gabriele.delmonte@proton.me> * spotless Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Gabriele Del Monte <gabriele.delmonte@proton.me> Signed-off-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * [CHANGELOG] consolidate upcoming breaking changes (#9030) * remove unnecessary use of deprecated options * changelog Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * use dummy coinbase in simulation if not defined (#9031) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Use system call for beacon root (#8982) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Backward sync - check we have peers before starting (#9003) * check if ready before first step * add peer count > 0 check to isReady * added a test for zero peers Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Fix mixHash / prevRandao deserialization in BlockOverrides (#8983) * Fix mixHash / prevRandao deserialization in BlockOverrides Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Update plugin-api checksum Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Add deserialization test failing on main and passing on this branch Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Update ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/BlockOverridesParameterTest.java Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Apply formatter Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> --------- Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Feat: add gas usage metric on eth_call (#9019) * WIP: update EthCall.java to capture gas usage metric * update EthJsonRpcMethods.java and JsonRpcMethodsFactory.java constructors to include metricsSystem * Update EthCallTest.java to mock gas usage metric * Update transactionSimulator error label to internal_error * Update CHANGELOG.md Signed-off-by: Reuben George <reubengeorge101@gmail.com> --------- Signed-off-by: Reuben George <reubengeorge101@gmail.com> Signed-off-by: Reuben George <69674713+georgereuben@users.noreply.github.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Remove CLI options for JMH and adapt benchmarks (#9025) PR allows for changing JMH settings in benchmarks themselves instead of gradle plugin but fixes forks to 3 for all benchamrks. Also done some tuning of CLZ and Keccak benchmarks. * [CHARTER] make explicit the voting for emeritus process (#8937) * make explicit the voting for emeritus process Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * headings formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> * Bump prioritized transactions for blobs (#9037) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Removed BlockExplorer and AbstractBlockScheduler due single implementation. (#9026) Signed-off-by: Marcos Serradilla Diez <marcos@io.builders> * sonarcloud failing due to deprecated actions/cache version (#9036) * sonarcloud failing due to deprecated actions/cache version Signed-off-by: jflo <justin+github@florentine.us> * new release just dropped Signed-off-by: jflo <justin+github@florentine.us> --------- Signed-off-by: jflo <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Include authorization list in the transaction call object and use it when building transaction during simulation (#8984) * Include code delegation authorizations in the call parameter and use when building transaction during simulation Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Add authorizationList deserialization test Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Test that transaction type is correct if authorizations present in call param Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Add javadoc Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Extract TransactionCallParameterBuilder creation to a separate method for consistency Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Include codeDelegationAuthorizations when building Transaction from CallParameter Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> --------- Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * Improve P256Verify precompile performance (#9035) - Upgrade besu-native to 1.4.0. - Use BoringSSL by default and fallback to SECP256R1 signature algorithm which has its own native library (as well as Java fallback). - Add --Xp256verify-native-enabled to disable BoringSSL. - P256VerifyBenchmark switches between BoringSSL and Java. - Fixup P256VerifyBenchmark testcase names so they don't override each other in the Map. Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * update checkout action to 4.2.2 (#9052) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * EngineNewPayload - respond with error if params invalid (#8729) * added test for duplicate requests * most errors don't result in INVALID status * return invalid for invalid block * new error code * changelog entry Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> * Fix merge main Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> --------- Signed-off-by: Olexandr88 <radole1203@gmail.com> Signed-off-by: Jason Frame <jasonwframe@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net> Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Signed-off-by: Gabriele Del Monte <gabriele.delmonte@proton.me> Signed-off-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> Signed-off-by: Reuben George <reubengeorge101@gmail.com> Signed-off-by: Reuben George <69674713+georgereuben@users.noreply.github.com> Signed-off-by: Marcos Serradilla Diez <marcos@io.builders> Co-authored-by: Olexandr88 <radole1203@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jason Frame <jasonwframe@gmail.com> Co-authored-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Matilda-Clerke <matilda.clerke@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: ahamlat <ameziane.hamlat@consensys.net> Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Preeti <35308865+pr9t@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Miroslav Kovar <miroslavkovar@protonmail.com> Co-authored-by: Reuben George <69674713+georgereuben@users.noreply.github.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Luis Pinto <luis.pinto@consensys.net> Co-authored-by: Marcos Serradilla Diez <marcos@io.builders> Co-authored-by: garyschulte <garyschulte@gmail.com>

* check if ready before first step * add peer count > 0 check to isReady * added a test for zero peers Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* check if ready before first step * add peer count > 0 check to isReady * added a test for zero peers Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>

macfarla added 3 commits July 25, 2025 11:03

check if ready before first step

50964b4

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

add peer count > 0 check to isReady

2bbe3ff

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

fix test

f64174e

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla marked this pull request as ready for review August 1, 2025 00:22

macfarla mentioned this pull request Aug 1, 2025

Backward sync stuck on a specific (invalid) block #8404

Closed

pinges reviewed Aug 5, 2025

View reviewed changes

macfarla added 3 commits August 5, 2025 16:16

Merge branch 'main' of github.com:hyperledger/besu into backward-sync…

35cbac8

…-wait-for-peers

changelog

95a4c36

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

added a test for zero peers

00a7a4c

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

pinges approved these changes Aug 5, 2025

View reviewed changes

macfarla enabled auto-merge (squash) August 5, 2025 07:03

macfarla assigned pinges Aug 5, 2025

macfarla merged commit cb582e6 into hyperledger:main Aug 5, 2025
46 checks passed

macfarla deleted the backward-sync-wait-for-peers branch August 5, 2025 22:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backward sync - check we have peers before starting #9003

Backward sync - check we have peers before starting #9003

Uh oh!

macfarla commented Jul 25, 2025 •

edited

Loading

Uh oh!

macfarla commented Jul 30, 2025

Uh oh!

macfarla commented Aug 1, 2025 •

edited

Loading

Uh oh!

macfarla commented Aug 1, 2025

Uh oh!

pinges Aug 5, 2025

Uh oh!

macfarla Aug 5, 2025

Uh oh!

pinges left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Backward sync - check we have peers before starting #9003

Backward sync - check we have peers before starting #9003

Uh oh!

Conversation

macfarla commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

macfarla commented Jul 30, 2025

Uh oh!

macfarla commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macfarla commented Aug 1, 2025

Uh oh!

pinges Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

macfarla Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

pinges left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

macfarla commented Jul 25, 2025 •

edited

Loading

macfarla commented Aug 1, 2025 •

edited

Loading