Skip to content

Conversation

@Gabriel-Trintinalia
Copy link
Contributor

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Olexandr88 and others added 30 commits July 22, 2025 09:56
* Update README.md

Signed-off-by: Olexandr88 <radole1203@gmail.com>

* Update README.md

Signed-off-by: Jason Frame <jasonwframe@gmail.com>

---------

Signed-off-by: Olexandr88 <radole1203@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Jason Frame <jasonwframe@gmail.com>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
* getBlobsV2 to not return partial responses

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* Change precompile name in eth_config

The precompile names for bn254 were encoded as bn256, which is a widely
used but incorrect name. The EIP specified alt_bn128, for 128 bits of
security, but cryptographic analysis has shown the security to be less
than 128 bits, so the name referring to the field size is preferred.

Signed-off-by: Danno Ferrin <danno@numisight.com>

* fixed test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* update tests to use non-deprecated method
* remove deprecated method
* remove getValue methods that overrode the removed method

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…perledger#8975)

* Clean up production of the fastSyncFactory in DefaultSynchronizer

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix NPE caused by using a mock SynchronizerConfiguration

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix NPE caused by using a mock SynchronizerConfiguration

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* spotless

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Avoid using syncMode directly

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

---------

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…#8940)

* remove deprecated interfaces
* update plugin api hash

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…r#8819)

* made a constant

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Add world view to trace start block

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* change known hash

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* fix unit tests

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…er#8949)

* Delete PoW ATs which were replaced by QBFT miner based ATs
* Change another AT to used QBFT genesis
* update node config to fix couple of AT failures
* Update transaction validator AT to use 4 validators in QBFT cluster
* Update Besueventsplugintest
* Revert an accidentally deleted AT and now modified to use QBFT

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>

---------

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
* fix docker build

Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>

* update docker labels to the new oci standard

Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>

---------

Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
…erledger#8959)

* By not decoding the bodies we use less memory and CPU, which allows us to increase the chain download parallelism.

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Use maxRequestContentLength for EngineJsonRpcService bodyLimit and increase default value from 5MB to 128MB.
This has a side effect of increasing the JsonRpcService limit.

Use maxRequestContentLength to globally set maxStringLength for Vertx ObjectMapper when engine API enabled.
Reusing maxRequestContentLength to keep aligned with HTTP body limit.
String length should be comparable with byte size assuming UTF-8 encoding.

Also remove redundant serialization of params for optionalList
Similar to hyperledger#8807

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…#8985)

This means running all the test cases within one warmup or exec iteration in an attempt to invalidate CPU caches.

Requires tracking exec timings in a map and calculating average at the end.

Reduce warmup iteration to 20_000 and execution iterations to 1000, which appears to be as stable as 100_000.
This helps reduces overall benchmark execution time (previously warmTime and execTime were prematurely reducing overall execution time).

Use SequencedMap to indicate test case ordering matters.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
* handle empty bytes

* check for empty before getting tx type

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…perledger#9005)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* remove eth/67 capability

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* fix naming

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* changelog

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix mock test

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix tests

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* fix tests

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update CHANGELOG.md

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…dger#8898)

* Chore: Prevent repeated cli boolean flags for being accepted

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>

* allow unmatched options

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
…rledger#8885)

Merge AbstractRLPInput (607 lines) and BytesValueRLPInput (84 lines) into a
single concrete class implementing RLPInput directly. This eliminates the
unnecessary abstraction layer where the abstract class had only one concrete
implementation.

Changes:
- Merged all AbstractRLPInput logic into BytesValueRLPInput
- Made previously protected methods private
- Removed AbstractRLPInput.java file
- All public APIs remain unchanged (zero breaking changes)
- All tests pass unchanged

Benefits:
- Eliminates 15-30 minutes investigation time per RLP modification
- Reduces cognitive load when working with RLP functionality
- Simplifies maintenance with single concrete implementation
- No performance or functionality impact

Fixes hyperledger#8884

🤖 Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: jflo <justin+github@florentine.us>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Change eth_config hashing and config members

- Remove ConfigHash
- move ForkID into config
- invert key/value of precompiles

Signed-off-by: Danno Ferrin <danno@numisight.com>

* linting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* Add --era1-import-prepipeline-enabled and --era1-data-path flags

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Implement ERA1 file import prepipeline for full sync

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Filter out block 0 as this is included by default

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix SynchronizerOptionsTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* spotless

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix BesuCommandTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add ability to load ERA1 files direct from HTTP source, fix bug in Era1Reader exposed by using HTTP source

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix Era1ReaderTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add javadoc to InputStreamFactory

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add default constructor to InputStreamFactory

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix Era1FileSourceTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Only produce era1 import prepipeline if sync mode is FULL

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Make era1 prepipeline concurrency configurable

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Use Integer instead of int in SynchronizerOptions

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Update era1 import prepipeline concurrency to 1

Since the bottleneck for this pipeline is typically the import block step, there is no need for more concurrency than a single pipeline gives.

Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

* Inline starting full sync chain downloader

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Simplify comment

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Use constant for era1 block count

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Use Era1FileReader as a launching point for more worker threads to achieve better parallelism

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

---------

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
…erledger#8890)

- Consolidate AbstractRLPOutput logic into BytesValueRLPOutput
- Remove unnecessary inheritance layer with single implementation
- Maintain identical public API and functionality
- Zero breaking changes to 150+ usage sites across codebase

This follows the same pattern as recent AbstractRLPInput elimination,
completing the removal of premature abstractions in the RLP module.

Fixes hyperledger#8889

🤖 Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: jflo <justin+github@florentine.us>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 947ec72 into hyperledger:fusaka-devnet-3 Aug 2, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.