Skip to content

Conversation

@macfarla
Copy link
Contributor

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

using gw dependencies, verified that the version is overridden to 4.2.4-Final eg

|    |    +--- io.netty:netty-codec-http:4.1.118.Final -> 4.2.4.Final (c)
|    |    +--- io.netty:netty-codec-http2:4.1.118.Final -> 4.2.4.Final (c)

<sha256 value="9dd848900f5cb2a23aafd3321f04fc757c49305c20cd41d17f559950cb77bdbf" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-bom" version="4.1.107.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the old netty versions be removed from the verification metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #9114

@macfarla macfarla merged commit 095da6c into hyperledger:main Aug 27, 2025
46 checks passed
siladu pushed a commit to siladu/besu that referenced this pull request Aug 28, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the update-netty branch August 28, 2025 07:06
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
georgereuben pushed a commit to georgereuben/besu that referenced this pull request Sep 16, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: georgereuben <reubengeorge101@gmail.com>
georgereuben pushed a commit to georgereuben/besu that referenced this pull request Sep 16, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: georgereuben <reubengeorge101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants