fix(evm): correct P256VERIFY input length in error message #9137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine James <antoine@ethereum.org>
fab-10
reviewed
Aug 29, 2025
| if (input.size() != 160) { | ||
| LOG.warn( | ||
| "Invalid input length for P256VERIFY precompile: expected 128 bytes but got {}", | ||
| "Invalid input length for P256VERIFY precompile: expected 160 bytes but got {}", |
Contributor
There was a problem hiding this comment.
Good catch, but what if you create a constant for the value, even if the value is not meant to change it would have avoid the error in the first place, so it is a good practice.
Signed-off-by: Antoine James <antoine@ethereum.org>
fab-10
reviewed
Aug 29, 2025
evm/src/main/java/org/hyperledger/besu/evm/precompile/P256VerifyPrecompiledContract.java
Outdated
Show resolved
Hide resolved
…fyPrecompiledContract.java Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
approved these changes
Aug 29, 2025
Contributor
Author
|
thanks, forgot about it! |
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
…er#9137) * fix(evm): correct P256VERIFY input length in error message Signed-off-by: Antoine James <antoine@ethereum.org> * chore(evm): replaced hardcoded value with constant Signed-off-by: Antoine James <antoine@ethereum.org> * Update evm/src/main/java/org/hyperledger/besu/evm/precompile/P256VerifyPrecompiledContract.java Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Antoine James <antoine@ethereum.org> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
…er#9137) * fix(evm): correct P256VERIFY input length in error message Signed-off-by: Antoine James <antoine@ethereum.org> * chore(evm): replaced hardcoded value with constant Signed-off-by: Antoine James <antoine@ethereum.org> * Update evm/src/main/java/org/hyperledger/besu/evm/precompile/P256VerifyPrecompiledContract.java Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Antoine James <antoine@ethereum.org> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>
georgereuben
pushed a commit
to georgereuben/besu
that referenced
this pull request
Sep 16, 2025
…er#9137) * fix(evm): correct P256VERIFY input length in error message Signed-off-by: Antoine James <antoine@ethereum.org> * chore(evm): replaced hardcoded value with constant Signed-off-by: Antoine James <antoine@ethereum.org> * Update evm/src/main/java/org/hyperledger/besu/evm/precompile/P256VerifyPrecompiledContract.java Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Antoine James <antoine@ethereum.org> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: georgereuben <reubengeorge101@gmail.com>
georgereuben
pushed a commit
to georgereuben/besu
that referenced
this pull request
Sep 16, 2025
…er#9137) * fix(evm): correct P256VERIFY input length in error message Signed-off-by: Antoine James <antoine@ethereum.org> * chore(evm): replaced hardcoded value with constant Signed-off-by: Antoine James <antoine@ethereum.org> * Update evm/src/main/java/org/hyperledger/besu/evm/precompile/P256VerifyPrecompiledContract.java Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Antoine James <antoine@ethereum.org> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: georgereuben <reubengeorge101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Closes #9136
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests