Improve CallDataCopyOperation worst case #9152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improve a worst case scenario performance spotted by EEST memory tests on CallDataCopy opcode.
Surprisingly, the benchmarks showed that CallDataCopy performs worst when there's no actual data to copy, and this is related to the overhead of decoding the 3 values popped from the stack.
This PR implements an improvement for this case (data size = 0), to not decode the source offset if the number of bytes to copy is 0, and return directly the result.
Before this PR
With this PR
There is between 18 and 27 % improvement on zero data use case.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests