Implement optional sender balance checks in the layered txpool #9176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
layer-tx-pool-balance-aware
branch
4 times, most recently
from
d715f8f to
c7c876e
Compare
jflo
reviewed
Sep 17, 2025
Contributor
jflo
left a comment
jflo
left a comment
There was a problem hiding this comment.
A few comments inline, and a possible edge case which I'm not sure the testing covers.
...eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPoolFactory.java
Outdated
Show resolved
Hide resolved
.../org/hyperledger/besu/ethereum/eth/transactions/layered/AbstractPrioritizedTransactions.java
Show resolved
Hide resolved
...c/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/SenderBalanceChecker.java
Show resolved
Hide resolved
fab-10
force-pushed
the
layer-tx-pool-balance-aware
branch
from
c7c876e to
0ec79a7
Compare
jflo
approved these changes
Sep 18, 2025
Contributor
Author
fab-10
force-pushed
the
layer-tx-pool-balance-aware
branch
from
328aaae to
d2a0959
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
layer-tx-pool-balance-aware
branch
from
d2a0959 to
b227217
Compare
fab-10
added
the
doc-change-required
bgravenorst
removed
the
doc-change-required
AliZDev-v0
pushed a commit
to AliZDev-v0/besu
that referenced
this pull request
Oct 5, 2025
…dger#9176) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Ali Zhagparov <alijakparov.kz@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 13, 2025
…dger#9176) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Built on top of #9191 and #9192
please review them first
This PR introduces a new configuration option
tx-pool-enable-balance-check, false by default, that when enabled, will make sure that pending transactions, which sender hasn't enough balance to pay their fee, cannot be in the prioritized layer, thus preventing them to occupy space there and potentially be selected for block production.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests