Manage unexpected exceptions during block creation #9208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
manage-unexpected-exceptions-during-block-creation
branch
2 times, most recently
from
c5b2715 to
86d4b06
Compare
fab-10
force-pushed
the
manage-unexpected-exceptions-during-block-creation
branch
3 times, most recently
from
830830c to
63a68ac
Compare
8 tasks
macfarla
approved these changes
Sep 25, 2025
...n/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java
Show resolved
Hide resolved
macfarla
reviewed
Sep 25, 2025
| return richBenefactorTwo; | ||
| } | ||
|
|
||
| public Account getThirdBenefactor() { |
Contributor
Author
There was a problem hiding this comment.
the method itself is not used, but Accounts.GENESIS_ACCOUNT_THREE_PRIVATE_KEY is, so for uniformity with the other 2 account I also added this method
macfarla
reviewed
Sep 25, 2025
CHANGELOG.md
Outdated
| - Configurable limit for how much time plugins are allowed take, to propose transactions, during block creation [#9184](https://github.com/hyperledger/besu/pull/9184) | ||
| - Add Osaka, BPO1 and BPO2 fork times for holesky, hoodi and sepolia [#9196](https://github.com/hyperledger/besu/pull/9196/files) | ||
| - Implement optional sender balance checks in the layered txpool [#9176](https://github.com/hyperledger/besu/pull/9176) | ||
| - Manage unexpected exceptions during block creation [#9208](https://github.com/hyperledger/besu/pull/9208) |
Contributor
There was a problem hiding this comment.
needs moving out of 25.9.0
macfarla
approved these changes
Sep 25, 2025
plugin-api/src/main/java/org/hyperledger/besu/plugin/data/TransactionSelectionResult.java
Outdated
Show resolved
Hide resolved
plugin-api/src/main/java/org/hyperledger/besu/plugin/data/TransactionSelectionResult.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
manage-unexpected-exceptions-during-block-creation
branch
from
63a68ac to
be37644
Compare
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
manage-unexpected-exceptions-during-block-creation
branch
from
0768c8e to
6e3cdfb
Compare
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
manage-unexpected-exceptions-during-block-creation
branch
from
6e3cdfb to
f8403ac
Compare
10 tasks
AliZDev-v0
pushed a commit
to AliZDev-v0/besu
that referenced
this pull request
Oct 5, 2025
* Manage unexpected exceptions during block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Apply suggestion from @macfarla Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Apply suggestion from @macfarla Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Ali Zhagparov <alijakparov.kz@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 13, 2025
* Manage unexpected exceptions during block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Apply suggestion from @macfarla Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Apply suggestion from @macfarla Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adding protection against unexpected runtime exceptions that could be triggered by plugins, or internally, during block creation.
These exceptions are treat like internal errors, because they should have been handled, so they represent bugs and for that reason are logged as error for high visibility, and to avoid possible a inconsistent state a rollback is forced, so that the selection can continue with a clean state.
Fixed Issue(s)
fixes #9167
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests