Fix an error on eth_subscribe deserializing the block #9212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes a Json decoding error on eth_subscribe by using a Jackson mapper with jdk8 support. This is due to the addition of
Optional<BlockAccessListResult>on theBlockResult.I've created a Jackson mapper in the
SubscriptionManagerto use instead of using the vertxJsonlibrary. It would be ideal to pass in Jackson mapper instead but there didn't seem to be one readably available where theSubscriptionManageris created.This is the error we get:
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests…
Signed-off-by: Jason Frame jason.frame@consensys.net