Improve performance on EQ operation #9229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pinto
force-pushed
the
speed-up-eq
branch
2 times, most recently
from
78d0a1b to
821cc16
Compare
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
ahamlat
reviewed
Oct 1, 2025
| {"0x000001", "0x", Condition.NOT_EQUAL}, | ||
| {"0x000000", "0x", Condition.EQUAL}, | ||
| {"0x321312", "0x321312", Condition.EQUAL}, | ||
| {"0x321312", "0x0000321312", Condition.EQUAL}, |
Contributor
There was a problem hiding this comment.
Could you add a test with something like
{"0x00321312", "0x03213120", Condition.NOT_EQUAL},
AliZDev-v0
pushed a commit
to AliZDev-v0/besu
that referenced
this pull request
Oct 5, 2025
improves EQ performance by ~2x in some of the worst cases Signed-off-by: Ali Zhagparov <alijakparov.kz@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 13, 2025
improves EQ performance by ~2x in some of the worst cases Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already a ~10 ns operation but this PR is set to improve a little bit more in the worse cases (leading zeros and long byte matches) by inlining algorithm from Tuweni directly in besu and levering intrinsics.
Results below:
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests