fix test for wei formatting #9231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nethoxa thanks for the PR. Is this the only test that is failing when run locally for you? |
Contributor
|
thinking about this further - would it make more sense to update the test instead, so that any log messages appear in user's locale formatting. Change the test to also use String.format |
Signed-off-by: nethoxa <nethoxa@proton.me>
nethoxa
force-pushed
the
fix-wei-fmt
branch
from
925a269 to
680c83d
Compare
Signed-off-by: nethoxa <nethoxa@proton.me>
Signed-off-by: nethoxa <nethoxa@proton.me>
Contributor
Author
|
like that @macfarla? |
macfarla
approved these changes
Sep 30, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
AliZDev-v0
pushed a commit
to AliZDev-v0/besu
that referenced
this pull request
Oct 5, 2025
* fix wei formatting Signed-off-by: nethoxa <nethoxa@proton.me> * apply changes to wei fmt Signed-off-by: nethoxa <nethoxa@proton.me> * fix toHumanReadablePaddedString Signed-off-by: nethoxa <nethoxa@proton.me> --------- Signed-off-by: nethoxa <nethoxa@proton.me> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Ali Zhagparov <alijakparov.kz@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 13, 2025
* fix wei formatting Signed-off-by: nethoxa <nethoxa@proton.me> * apply changes to wei fmt Signed-off-by: nethoxa <nethoxa@proton.me> * fix toHumanReadablePaddedString Signed-off-by: nethoxa <nethoxa@proton.me> --------- Signed-off-by: nethoxa <nethoxa@proton.me> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
toHumanReadableStringWithPaddingthat was making some tests to failThanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests