Skip to content

Fix: colored output is lost with 25.7.0 #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macfarla merged 3 commits into from
Oct 6, 2025
Merged

Fix: colored output is lost with 25.7.0 #9250

macfarla merged 3 commits into from
Oct 6, 2025

Conversation

@jintukumardas
Copy link
Contributor

@jintukumardas jintukumardas commented Sep 30, 2025 •
edited by macfarla
Loading

PR description

Fixes colored output in terminal logging

Fixed Issue(s)

fixes #8908

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla
Copy link
Contributor

macfarla commented Sep 30, 2025

tested locally and this works for me
Screenshot 2025-10-01 at 6 34 15 am

@jintukumardas you'll need to add signoff to your git commits for DCO to pass. follow the instructions here

@jintukumardas
Copy link
Contributor Author

jintukumardas commented Sep 30, 2025

tested locally and this works for me Screenshot 2025-10-01 at 6 34 15 am

@jintukumardas you'll need to add signoff to your git commits for DCO to pass. follow the instructions here

Thanks for testing and sharing the update. I've added the signoff now. Thanks again!

@macfarla macfarla assigned macfarla and unassigned jintukumardas Sep 30, 2025
@macfarla
Copy link
Contributor

macfarla commented Oct 1, 2025

@jintukumardas I added a changelog entry but DCO is also broken again from your most recent commit. can you take a look please

@macfarla macfarla assigned jintukumardas and unassigned macfarla Oct 1, 2025
@macfarla macfarla marked this pull request as draft October 1, 2025 06:19
@jintukumardas
Copy link
Contributor Author

jintukumardas commented Oct 1, 2025 •
edited
Loading

@macfarla Apologies, the rebase without signoff seems to have caused the issue. It's been fixed now, thank you.

If changelog was part of this PR, I may have overwritten it by force push.

@jintukumardas
Copy link
Contributor Author

jintukumardas commented Oct 3, 2025

@macfarla I've pushed the DCO changes and wanted to check if I should mark this as ready for review?

macfarla
macfarla reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jintukumardas - can you please add a changelog entry, since this is fixing an open issue. Thanks!

@jintukumardas
Fix colored output in terminal
152ca9d 
Signed-off-by: Jintu Das <jintuisbusy@gmail.com>
@jintukumardas
Update CHANGELOG
d5b576f 
Signed-off-by: Jintu Das <jintuisbusy@gmail.com>
@jintukumardas jintukumardas requested a review from macfarla October 6, 2025 09:57
@jintukumardas
Copy link
Contributor Author

jintukumardas commented Oct 6, 2025

Hi @macfarla , I've added the changelog entry, thanks!

@macfarla macfarla marked this pull request as ready for review October 6, 2025 22:11
@macfarla macfarla assigned macfarla and unassigned jintukumardas Oct 6, 2025
macfarla
macfarla approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 42306f9 into hyperledger:main Oct 6, 2025
46 checks passed
@jintukumardas
Copy link
Contributor Author

jintukumardas commented Oct 7, 2025

@macfarla , thank you for reviewing and merging it.

jflo pushed a commit to jflo/besu that referenced this pull request Oct 13, 2025
@jintukumardas @macfarla @jflo
Fix: colored output is lost with 25.7.0 (hyperledger#9250)
bc0d98c 
* Fix colored output in terminal

Signed-off-by: Jintu Das <jintuisbusy@gmail.com>

* Update CHANGELOG

Signed-off-by: Jintu Das <jintuisbusy@gmail.com>

---------

Signed-off-by: Jintu Das <jintuisbusy@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
macfarla added a commit that referenced this pull request Oct 16, 2025
@macfarla
Revert "Fix: colored output is lost with 25.7.0 (#9250)"
d59df55 
This reverts commit 42306f9.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla added a commit to macfarla/besu that referenced this pull request Oct 16, 2025
@macfarla
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)"
767be2f 
This reverts commit 42306f9.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Gabriel-Trintinalia added a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 16, 2025
@Gabriel-Trintinalia
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)"
5ba4b75 
This reverts commit 42306f9.
Gabriel-Trintinalia added a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 16, 2025
@Gabriel-Trintinalia
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)"
55a2486 
This reverts commit 42306f9.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla pushed a commit that referenced this pull request Oct 16, 2025
@Gabriel-Trintinalia
Revert "Fix: colored output is lost with 25.7.0 (#9250)" (#9320)
6f65381 
This reverts commit 42306f9.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla added a commit that referenced this pull request Oct 16, 2025
@macfarla
Revert "Fix: colored output is lost with 25.7.0 (#9250)" (#9321)
7c3bc92 
* Revert "Fix: colored output is lost with 25.7.0 (#9250)"

This reverts commit 42306f9.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* changelog

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* kudos

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
@Gabriel-Trintinalia @pinges
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)" (h…
1cdb79d 
…yperledger#9320)

This reverts commit 42306f9.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macfarla macfarla macfarla approved these changes

Assignees

@macfarla macfarla

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Colored output is lost with 25.7.0

2 participants

@jintukumardas @macfarla