Skip to content

add blockTimestamp to logs within tx receipt #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macfarla merged 3 commits into from
Oct 14, 2025
Merged

add blockTimestamp to logs within tx receipt #9294

macfarla merged 3 commits into from
Oct 14, 2025

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 13, 2025 •
edited
Loading

add blockTimestamp to logs within tx receipt and block receipts

PR description

Fixed Issue(s)

Follow up for #9276

Fixes 4 hive tests:

  • eth_getBlockReceipts/get-block-receipts-latest
  • eth_getTransactionReceipt/get-access-list
  • eth_getTransactionReceipt/get-blob-tx
  • eth_getTransactionReceipt/get-dynamic-fee

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla
add block timestamp to logs within transaction receipt and block rece…
1daac14 
…ipts

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
changelog
7ae7b6e 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added RPC hive relating to hive tests labels Oct 13, 2025
Gabriel-Trintinalia
Gabriel-Trintinalia approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@macfarla macfarla enabled auto-merge (squash) October 14, 2025 04:52
@macfarla macfarla merged commit c747dec into hyperledger:main Oct 14, 2025
46 checks passed
@macfarla macfarla deleted the blocktimestamp-in-block-receipt-logs branch October 15, 2025 03:35
pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
@macfarla @pinges
add blockTimestamp to logs within tx receipt (hyperledger#9294)
33ffa3a 
* add block timestamp to logs within transaction receipt and block receipts

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia approved these changes

Assignees

No one assigned

Labels

hive relating to hive tests RPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macfarla @Gabriel-Trintinalia