-
Notifications
You must be signed in to change notification settings - Fork 995
tuweni 2.7.2 #9338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuweni 2.7.2 #9338
Conversation
Matilda-Clerke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do the trick as-is, but I've raised a few concerns below
| <sha256 value="1033325d520096a16f7119c148c2d455b9cbb517c2c4dcd7950e3542cc08e0a1" origin="Generated by Gradle"/> | ||
| </artifact> | ||
| </component> | ||
| <component group="io.consensys.tuweni" name="tuweni-units" version="2.7.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, we're including tuweni-units-2.7.0 and tuweni-units-2.7.2? Can we delete the older version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. deleting the 2.7.0 jar+pom from the metadata file results in a build error so I guess they are in the dependency chain somewhere
gw compileTestJava
...
* What went wrong:
A problem occurred configuring project ':acceptance-tests:tests'.
> Dependency verification failed for configuration 'classpath'
2 artifacts failed verification:
- tuweni-bytes-2.7.0.jar (io.consensys.tuweni:tuweni-bytes:2.7.0) from repository Gradle Central Plugin Repository
- tuweni-bytes-2.7.0.pom (io.consensys.tuweni:tuweni-bytes:2.7.0) from repository Gradle Central Plugin Repository
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file. For more on how to do this, please refer to https://docs.gradle.org/8.14/userguide/dependency_verification.html#sec:troubleshooting-verification in the Gradle documentation.
even without this PR, we have a mix of both 2.7.1 and 2.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the platform build.gradle solved this problem
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This reverts commit 767caf6. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* tuweni 2.7.2 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
* tuweni 2.7.2 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* tuweni 2.7.2 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Sally MacFarlane macfarla.github@gmail.com
PR description
Update to tuweni 2.7.2 https://github.com/Consensys/tuweni/releases/tag/v2.7.2
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests