Skip to content

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 20, 2025

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Update to tuweni 2.7.2 https://github.com/Consensys/tuweni/releases/tag/v2.7.2

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla marked this pull request as draft October 20, 2025 23:35
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla marked this pull request as ready for review October 22, 2025 01:49
Copy link
Contributor

@Matilda-Clerke Matilda-Clerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do the trick as-is, but I've raised a few concerns below

<sha256 value="1033325d520096a16f7119c148c2d455b9cbb517c2c4dcd7950e3542cc08e0a1" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.consensys.tuweni" name="tuweni-units" version="2.7.0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, we're including tuweni-units-2.7.0 and tuweni-units-2.7.2? Can we delete the older version?

Copy link
Contributor Author

@macfarla macfarla Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. deleting the 2.7.0 jar+pom from the metadata file results in a build error so I guess they are in the dependency chain somewhere

gw compileTestJava
...
* What went wrong:
A problem occurred configuring project ':acceptance-tests:tests'.
> Dependency verification failed for configuration 'classpath'
  2 artifacts failed verification:
    - tuweni-bytes-2.7.0.jar (io.consensys.tuweni:tuweni-bytes:2.7.0) from repository Gradle Central Plugin Repository
    - tuweni-bytes-2.7.0.pom (io.consensys.tuweni:tuweni-bytes:2.7.0) from repository Gradle Central Plugin Repository
  If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file. For more on how to do this, please refer to https://docs.gradle.org/8.14/userguide/dependency_verification.html#sec:troubleshooting-verification in the Gradle documentation.

even without this PR, we have a mix of both 2.7.1 and 2.7.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the platform build.gradle solved this problem

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This reverts commit 767caf6.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla self-assigned this Oct 23, 2025
@macfarla macfarla merged commit 66d4f58 into hyperledger:main Oct 23, 2025
46 checks passed
@macfarla macfarla deleted the tuweni-up branch October 23, 2025 22:16
mirgee pushed a commit to mirgee/besu that referenced this pull request Oct 24, 2025
* tuweni 2.7.2

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Nov 17, 2025
* tuweni 2.7.2

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
* tuweni 2.7.2

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants