create access list - return success response even if tx reverted #9358
+32
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla
added
doc-change-required
siladu
reviewed
Oct 26, 2025
...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCreateAccessList.java
Outdated
Show resolved
Hide resolved
macfarla
added
the
breaking
Gabriel-Trintinalia
approved these changes
Nov 4, 2025
alexandratran
removed
the
doc-change-required
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 17, 2025
…erledger#9358) * create access list return success response even if tx reverted Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pinges
pushed a commit
to pinges/besu
that referenced
this pull request
Dec 15, 2025
…erledger#9358) * create access list return success response even if tx reverted Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
eth_createAccessList should return success response even if tx reverted.
Discussion in json-rpc-api channel in discord, conclusion is
refer these commits to execution-apis repo
ethereum/execution-apis@f3544e8
ethereum/execution-apis@9772380
Fixed Issue(s)
Fixes this new hive test
eth_createAccessList/create-al-abi-revertrefs #5377
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests